Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upPotential fix for #2335. #2411
Potential fix for #2335. #2411
Conversation
hoppipolla-critic-bot
commented
May 13, 2014
|
Critic review: https://critic.hoppipolla.co.uk/r/1546 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
highfive
commented
May 13, 2014
|
|
I'm not sure if this is a reasonable fix or likely to cause other issues. It fixes the problems I'm aware of and the tests still seem to all pass. r? @pcwalton |
This comment has been minimized.
This comment has been minimized.
pcwalton
commented on 0bb5185
May 21, 2014
|
r+ |
This comment has been minimized.
This comment has been minimized.
|
saw approval from pcwalton |
This comment has been minimized.
This comment has been minimized.
|
merging glennw/servo/issue-2335 = 0bb5185 into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
all tests pass: |
This comment has been minimized.
This comment has been minimized.
|
fast-forwarding master to auto = 891ca73 |
0bb5185
into
servo:master
glennw commentedMay 13, 2014
No description provided.