Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential fix for #2335. #2411

Merged
merged 1 commit into from May 22, 2014
Merged

Potential fix for #2335. #2411

merged 1 commit into from May 22, 2014

Conversation

@glennw
Copy link
Member

glennw commented May 13, 2014

No description provided.

@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented May 13, 2014

Critic review: https://critic.hoppipolla.co.uk/r/1546

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@highfive
Copy link

highfive commented May 13, 2014

warning Warning warning

  • @glennw, please confirm that src/test/html/acid1.html and your favourite wikipedia page still render correctly!
@glennw
Copy link
Member Author

glennw commented May 13, 2014

I'm not sure if this is a reasonable fix or likely to cause other issues. It fixes the problems I'm aware of and the tests still seem to all pass.

r? @pcwalton

@pcwalton

This comment has been minimized.

Copy link

pcwalton commented on 0bb5185 May 21, 2014

r+

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented on 0bb5185 May 22, 2014

saw approval from pcwalton
at glennw@0bb5185

This comment has been minimized.

Copy link
Contributor

bors-servo replied May 22, 2014

merging glennw/servo/issue-2335 = 0bb5185 into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied May 22, 2014

glennw/servo/issue-2335 = 0bb5185 merged ok, testing candidate = 891ca73

This comment has been minimized.

Copy link
Contributor

bors-servo replied May 22, 2014

This comment has been minimized.

Copy link
Contributor

bors-servo replied May 22, 2014

fast-forwarding master to auto = 891ca73

@bors-servo bors-servo merged commit 0bb5185 into servo:master May 22, 2014
1 check passed
1 check passed
default all tests passed
@glennw glennw deleted the glennw:issue-2335 branch May 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.