Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the HoloLens UI look better #24126

Merged
merged 1 commit into from Sep 12, 2019
Merged

Make the HoloLens UI look better #24126

merged 1 commit into from Sep 12, 2019

Conversation

@paulrouget
Copy link
Contributor

paulrouget commented Sep 3, 2019 •
edited by SimonSapin

Throbber, icons, tooltips, alignment, etc...

Based on top of #24125

This change is Reviewable
@paulrouget
Copy link
Contributor Author

paulrouget commented Sep 4, 2019

  • Proper icons (from Firefox Desktop)
  • Reload/Stop collapse into one button
  • Throbber when page is loading

1
@jdm
Copy link
Member

jdm commented Sep 4, 2019

Does the browser still recognize voice commands like "back" and "refresh" with these changes?
@bors-servo
Copy link
Contributor

bors-servo commented Sep 6, 2019

☔ The latest upstream changes (presumably #24125) made this pull request unmergeable. Please resolve the merge conflicts.
@paulrouget
Copy link
Contributor Author

paulrouget commented Sep 9, 2019

Does the browser still recognize voice commands like "back" and "refresh" with these changes?

Nope. I'll see how to fix that.
@paulrouget paulrouget force-pushed the paulrouget:ui++ branch from 3a2cf66 to 2b066ce Sep 11, 2019
@paulrouget
Copy link
Contributor Author

paulrouget commented Sep 11, 2019

Does the browser still recognize voice commands like "back" and "refresh" with these changes?

Now it does.
@paulrouget
Copy link
Contributor Author

paulrouget commented Sep 11, 2019

Erf, pushed too many changes.
@paulrouget
Make the UI look better
Loading status checks…
19d9616
@paulrouget paulrouget force-pushed the paulrouget:ui++ branch from 2b066ce to 19d9616 Sep 11, 2019
@paulrouget
Copy link
Contributor Author

paulrouget commented Sep 11, 2019

r? @jdm
@highfive highfive assigned jdm and unassigned SimonSapin Sep 11, 2019
@jdm
Copy link
Member

jdm commented Sep 11, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Sep 11, 2019

📌 Commit 19d9616 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Sep 11, 2019

⌛ Testing commit 19d9616 with merge f69fe45...
bors-servo added a commit that referenced this pull request Sep 11, 2019
@bors-servo
Auto merge of #24126 - paulrouget:ui++, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f69fe45 
Make the HoloLens UI look better

Throbber, icons, tooltips, alignment, etc...

Based on top of #24125

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24126)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 11, 2019

💔 Test failed - status-taskcluster
@CYBAI
Copy link
Collaborator

CYBAI commented Sep 11, 2019

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Sep 11, 2019

⌛ Testing commit 19d9616 with merge 62f13e3...
bors-servo added a commit that referenced this pull request Sep 11, 2019
@bors-servo
Auto merge of #24126 - paulrouget:ui++, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
62f13e3 
Make the HoloLens UI look better

Throbber, icons, tooltips, alignment, etc...

Based on top of #24125

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24126)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 11, 2019

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented Sep 11, 2019

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Sep 11, 2019

⌛ Testing commit 19d9616 with merge 0abb9cb...
bors-servo added a commit that referenced this pull request Sep 11, 2019
@bors-servo
Auto merge of #24126 - paulrouget:ui++, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0abb9cb 
Make the HoloLens UI look better

Throbber, icons, tooltips, alignment, etc...

Based on top of #24125

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24126)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 12, 2019

💔 Test failed - status-taskcluster
@CYBAI
Copy link
Collaborator

CYBAI commented Sep 12, 2019

@bors-servo retry

  • UWP build OOM
@bors-servo
Copy link
Contributor

bors-servo commented Sep 12, 2019

💣 Failed to start rebuilding: Unknown error
@bors-servo
Copy link
Contributor

bors-servo commented Sep 12, 2019

⌛ Testing commit 19d9616 with merge f2b6cb7...
bors-servo added a commit that referenced this pull request Sep 12, 2019
@bors-servo
Auto merge of #24126 - paulrouget:ui++, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f2b6cb7 
Make the HoloLens UI look better

Throbber, icons, tooltips, alignment, etc...

Based on top of #24125

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24126)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 12, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: jdm
Pushing f2b6cb7 to master...
@bors-servo bors-servo merged commit 19d9616 into servo:master Sep 12, 2019
3 checks passed
3 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@paulrouget @jdm @bors-servo @CYBAI @SimonSapin @highfive
You can’t perform that action at this time.