Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade webxr #24134

Merged
merged 1 commit into from Sep 18, 2019
Merged

Upgrade webxr #24134

merged 1 commit into from Sep 18, 2019

Conversation

@paulrouget
Copy link
Contributor

paulrouget commented Sep 4, 2019 •
edited by SimonSapin

This change is Reviewable
@jdm
Copy link
Member

jdm commented Sep 4, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Sep 4, 2019

📌 Commit 53b5ac4 has been approved by jdm
@highfive highfive assigned jdm and unassigned SimonSapin Sep 4, 2019
@bors-servo
Copy link
Contributor

bors-servo commented Sep 4, 2019

⌛ Testing commit 53b5ac4 with merge 9792808...
bors-servo added a commit that referenced this pull request Sep 4, 2019
@bors-servo
Auto merge of #24134 - paulrouget:webxr-up, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9792808 
Upgrade webxr

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24134)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 4, 2019

💔 Test failed - linux-rel-wpt
@CYBAI
Copy link
Collaborator

CYBAI commented Sep 5, 2019 

{
    "status": "NOTRUN", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "end event fires when non-immersive session ends", 
    "test": "/webxr/xrSession_end.https.html", 
    "line": 291681, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "ERROR", 
    "group": "default", 
    "message": "Timeout while running cleanup for test named \"end event fires when immersive session ends\".", 
    "stack": null, 
    "subtest": null, 
    "test": "/webxr/xrSession_end.https.html", 
    "line": 291682, 
    "action": "test_result", 
    "expected": "OK"
}
{
    "status": "ERROR", 
    "group": "default", 
    "message": "Timeout while running cleanup for test named \"Calling end during an input callback stops processing at the right time\".", 
    "stack": null, 
    "subtest": null, 
    "test": "/webxr/xrSession_input_events_end.https.html", 
    "line": 327809, 
    "action": "test_result", 
    "expected": "OK"
}
@paulrouget
Copy link
Contributor Author

paulrouget commented Sep 13, 2019

servo/webxr#53 will solve these tests issues.
@paulrouget paulrouget force-pushed the paulrouget:webxr-up branch from 53b5ac4 to 8977e6e Sep 17, 2019
@paulrouget
Copy link
Contributor Author

paulrouget commented Sep 17, 2019

@bors-servo try=wpt
@bors-servo
Copy link
Contributor

bors-servo commented Sep 17, 2019

⌛ Trying commit 8977e6e with merge 0b5354a...
bors-servo added a commit that referenced this pull request Sep 17, 2019
@bors-servo
Auto merge of #24134 - paulrouget:webxr-up, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0b5354a 
Upgrade webxr

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24134)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 17, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
State: approved= try=True
@paulrouget
Copy link
Contributor Author

paulrouget commented Sep 17, 2019

@bors-servo r=jdm
@bors-servo
Copy link
Contributor

bors-servo commented Sep 17, 2019

📌 Commit 8977e6e has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Sep 17, 2019

⌛ Testing commit 8977e6e with merge 2613c4c...
bors-servo added a commit that referenced this pull request Sep 17, 2019
@bors-servo
Auto merge of #24134 - paulrouget:webxr-up, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
2613c4c 
Upgrade webxr

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24134)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 17, 2019

💔 Test failed - status-taskcluster
@CYBAI
Copy link
Collaborator

CYBAI commented Sep 17, 2019 

error[E0063]: missing field `is_running` in initializer of `magicleap::MagicLeapDevice`
   --> /Users/worker/.cargo/git/checkouts/webxr-702fa5244eec1e69/614c1b7/webxr/magicleap/mod.rs:158:26
    |
158 |         let mut device = MagicLeapDevice {
    |                          ^^^^^^^^^^^^^^^ missing `is_running`

error: aborting due to previous error
@paulrouget
webxr update
Loading status checks…
adc6fe7
@paulrouget paulrouget force-pushed the paulrouget:webxr-up branch from 8977e6e to adc6fe7 Sep 18, 2019
@paulrouget
Copy link
Contributor Author

paulrouget commented Sep 18, 2019

@bors-servo r=jdm
@bors-servo
Copy link
Contributor

bors-servo commented Sep 18, 2019

📌 Commit adc6fe7 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Sep 18, 2019

⌛ Testing commit adc6fe7 with merge 92e8d3a...
bors-servo added a commit that referenced this pull request Sep 18, 2019
@bors-servo
Auto merge of #24134 - paulrouget:webxr-up, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
92e8d3a 
Upgrade webxr

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24134)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 18, 2019

💔 Test failed - status-taskcluster
@CYBAI
Copy link
Collaborator

CYBAI commented Sep 18, 2019

@bors-servo retry

  • cygwin oom
@bors-servo
Copy link
Contributor

bors-servo commented Sep 18, 2019

⌛ Testing commit adc6fe7 with merge d75b7fd...
bors-servo added a commit that referenced this pull request Sep 18, 2019
@bors-servo
Auto merge of #24134 - paulrouget:webxr-up, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d75b7fd 
Upgrade webxr

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24134)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 18, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: jdm
Pushing d75b7fd to master...
@bors-servo bors-servo merged commit adc6fe7 into servo:master Sep 18, 2019
3 checks passed
3 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@paulrouget @jdm @bors-servo @CYBAI @SimonSapin @highfive
You can’t perform that action at this time.