Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use OpenXR loader from NuGet #24140

Merged
merged 2 commits into from Sep 6, 2019
Merged

Use OpenXR loader from NuGet #24140

merged 2 commits into from Sep 6, 2019
+8 −59

Conversation

@Manishearth
Copy link
Member

Manishearth commented Sep 4, 2019 •
edited by SimonSapin

No need to manually download the DLL

r? @jdm

This change is Reviewable
Manishearth added 2 commits Sep 4, 2019
@Manishearth
Use OpenXR Loader from NuGet
92bddf0
@Manishearth
Don't run msbuild if packaging failed
Loading status checks…
67f59f5
@highfive
Copy link

highfive commented Sep 4, 2019

Heads up! This PR modifies the following files:
@jdm
Copy link
Member

jdm commented Sep 4, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Sep 4, 2019

📌 Commit 67f59f5 has been approved by jdm
bors-servo added a commit that referenced this pull request Sep 5, 2019
@bors-servo
Auto merge of #24140 - Manishearth:nuget-openxr, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0cfd779 
Use OpenXR loader from NuGet

No need to manually download the DLL

r? @jdm

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24140)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 5, 2019

⌛ Testing commit 67f59f5 with merge 0cfd779...
@bors-servo
Copy link
Contributor

bors-servo commented Sep 5, 2019

💔 Test failed - linux-rel-wpt
@jdm
Copy link
Member

jdm commented Sep 5, 2019

@bors-servo retry
bors-servo added a commit that referenced this pull request Sep 5, 2019
@bors-servo
Auto merge of #24140 - Manishearth:nuget-openxr, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
2b31c0a 
Use OpenXR loader from NuGet

No need to manually download the DLL

r? @jdm

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24140)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 5, 2019

⌛ Testing commit 67f59f5 with merge 2b31c0a...
@bors-servo
Copy link
Contributor

bors-servo commented Sep 6, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: jdm
Pushing 2b31c0a to master...
@bors-servo bors-servo merged commit 67f59f5 into servo:master Sep 6, 2019
3 checks passed
3 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Sep 6, 2019
Merged
@paulrouget
Copy link
Contributor

paulrouget commented Sep 11, 2019

With this change, I keep getting this error:

RUST: WARN - webxr_api::registry - XR device error BackendSpecific("\"The specified module could not be found. (os error 126)\"")

Without this commit, no error.
@paulrouget paulrouget mentioned this pull request Sep 11, 2019
Closed
@Manishearth
Copy link
Member Author

Manishearth commented Sep 11, 2019

Make sure you restore nuget packages. You need to install the OpenXR package from the Windows Store as well.
@Manishearth Manishearth deleted the Manishearth:nuget-openxr branch Sep 11, 2019
@paulrouget
Copy link
Contributor

paulrouget commented Sep 12, 2019

Make sure you restore nuget packages. You need to install the OpenXR package from the Windows Store as well.

I've done all of that. I've very confused.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@Manishearth @highfive @jdm @bors-servo @paulrouget
You can’t perform that action at this time.