Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upShow warning when module scripts are ignored #24142
Merged
+168
−111
Conversation
highfive
commented
Sep 5, 2019
|
Heads up! This PR modifies the following files:
|
highfive
commented
Sep 5, 2019
|
|
|
r? @jdm |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Sep 6, 2019
Show warning when module scripts are ignored The first five commits are `cherry-pick`-ed from the module script PR. I think it might be also good to have this PR first so that reviewers can focus on module script things on that PR! --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #24089 - [x] These changes do not require tests because it just ignored module scripts (or should we turn on module script tests in this PR and update those test expectation to TIMEOUT?) <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24142) <!-- Reviewable:end -->
|
|
|
@bors-servo try=wpt |
bors-servo
added a commit
that referenced
this pull request
Sep 6, 2019
Show warning when module scripts are ignored The first five commits are `cherry-pick`-ed from the module script PR. I think it might be also good to have this PR first so that reviewers can focus on module script things on that PR! --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #24089 - [x] These changes do not require tests because it just ignored module scripts (or should we turn on module script tests in this PR and update those test expectation to TIMEOUT?) <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24142) <!-- Reviewable:end -->
|
|
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Sep 6, 2019
Show warning when module scripts are ignored The first five commits are `cherry-pick`-ed from the module script PR. I think it might be also good to have this PR first so that reviewers can focus on module script things on that PR! --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #24089 - [x] These changes do not require tests because it just ignored module scripts (or should we turn on module script tests in this PR and update those test expectation to TIMEOUT?) <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24142) <!-- Reviewable:end -->
|
|
This was referenced Sep 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
CYBAI commentedSep 5, 2019
•
edited by SimonSapin
The first five commits are
cherry-pick-ed from the module script PR.I think it might be also good to have this PR first so that reviewers can focus on module script things on that PR!
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is