Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show warning when module scripts are ignored #24142

Merged
merged 6 commits into from Sep 6, 2019
Merged

Show warning when module scripts are ignored #24142

merged 6 commits into from Sep 6, 2019
+168 −111

Commits on Sep 6, 2019

  1. Update spec step number

    @CYBAI
    CYBAI committed Sep 6, 2019
    96ed5ac

  2. Recognize `module` as script type

    @CYBAI
    CYBAI committed Sep 6, 2019
    47d8c57

  3. Rename ScriptContext to ClassicContext

    @CYBAI
    CYBAI committed Sep 6, 2019
    608c44f

  4. Rename ClassicScript to ScriptOrigin 

    This is basically revert 965370c. After introducing module script, we
can reuse this struct and add field to see the type of script.
    @CYBAI
    CYBAI committed Sep 6, 2019
    19eb239

  5. Add `type_` for script origin to distinguish module or classic

    @CYBAI
    CYBAI committed Sep 6, 2019
    70c5cfd

  6. Show warning when the script is a module 

    The warning can be removed in #23545.
    @CYBAI
    CYBAI committed Sep 6, 2019
    Loading status checks…
    95ddfb3
You can’t perform that action at this time.