Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove layout_2020::display_list, use WebRender display lists instead #24153

Merged
merged 3 commits into from Sep 9, 2019

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented Sep 6, 2019

This change is Reviewable

@highfive
Copy link

highfive commented Sep 6, 2019

Heads up! This PR modifies the following files:

  • @emilio: components/layout/display_list/items.rs, components/layout/display_list/webrender_helpers.rs, components/layout/display_list/mod.rs
@highfive
Copy link

highfive commented Sep 6, 2019

warning Warning warning

  • These commits modify layout code, but no tests are modified. Please consider adding a test!
@nox
Copy link
Member

nox commented Sep 6, 2019

@bors-servo
Copy link
Contributor

bors-servo commented Sep 6, 2019

📌 Commit c901f68 has been approved by nox

@highfive highfive assigned nox and unassigned avadacatavra Sep 6, 2019
@jdm
Copy link
Member

jdm commented Sep 6, 2019

@bors-servo r-

�[0m�[1m�[38;5;9merror[E0308]�[0m�[0m�[1m: mismatched types�[0m
�[0m  �[0m�[0m�[1m�[38;5;12m--> �[0m�[0mtests/unit/metrics/paint_time.rs:69:9�[0m
�[0m   �[0m�[0m�[1m�[38;5;12m|�[0m
�[0m�[1m�[38;5;12m69�[0m�[0m �[0m�[0m�[1m�[38;5;12m| �[0m�[0m        &*display_list,�[0m
�[0m   �[0m�[0m�[1m�[38;5;12m| �[0m�[0m        �[0m�[0m�[1m�[38;5;9m^^^^^^^^^^^^^^�[0m�[0m �[0m�[0m�[1m�[38;5;9mexpected bool, found reference�[0m
�[0m   �[0m�[0m�[1m�[38;5;12m|�[0m
�[0m   �[0m�[0m�[1m�[38;5;12m= �[0m�[0m�[1mnote�[0m�[0m: expected type `�[0m�[0m�[1mbool�[0m�[0m`�[0m
�[0m              found type `�[0m�[0m�[1m&layout::display_list::items::DisplayList�[0m�[0m`�[0m
@SimonSapin
Copy link
Member Author

SimonSapin commented Sep 7, 2019

Made the unit test to pass, though it’s arguably less meaningful now.

@nox
Copy link
Member

nox commented Sep 9, 2019

@bors-servo
Copy link
Contributor

bors-servo commented Sep 9, 2019

📌 Commit 3e6489f has been approved by nox

@bors-servo
Copy link
Contributor

bors-servo commented Sep 9, 2019

Testing commit 3e6489f with merge c2178ff...

bors-servo added a commit that referenced this pull request Sep 9, 2019
Remove layout_2020::display_list, use WebRender display lists instead

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24153)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 9, 2019

💔 Test failed - status-taskcluster

@CYBAI
Copy link
Collaborator

CYBAI commented Sep 9, 2019

@bors-servo
Copy link
Contributor

bors-servo commented Sep 9, 2019

💣 Failed to start rebuilding: Unknown error

@bors-servo
Copy link
Contributor

bors-servo commented Sep 9, 2019

Testing commit 3e6489f with merge 5bcb1b5...

bors-servo added a commit that referenced this pull request Sep 9, 2019
Remove layout_2020::display_list, use WebRender display lists instead

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24153)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 9, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: nox
Pushing 5bcb1b5 to master...

@bors-servo bors-servo merged commit 3e6489f into master Sep 9, 2019
3 checks passed
3 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@SimonSapin SimonSapin deleted the wr-dl branch Sep 9, 2019
@SimonSapin SimonSapin added this to Done / resolved in Layout 2020 Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Layout 2020
  
Merged / resolved
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
You can’t perform that action at this time.