Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplemented configurable logging through C API #23813. #24184
Closed
Conversation
angelortiz1007
force-pushed the
angelortiz1007:servo-vslogger
branch
from
74fcea0
to
98c98a7
|
@bors-servo r+ |
|
|
|
You are welcome! Let me know if you want to have 1 last zoom briefing exit. |
|
I won't be available for that, sadly. |
bors-servo
added a commit
that referenced
this pull request
Sep 12, 2019
Implemented configurable logging through C API #23813. <!-- Please describe your changes on the following line: --> In CInitOptions added the variable pub ptrfunc: Option<fn(*const c_char) -> bool> which is responsible for being assigned to an Option<> None, or to a function implemented in the C/C++ code. The C/C++ implemented function is a platform specific logger. In addition, vslogger.rs::log() function was modified to call this C/C++ platform specific function - if implemented - and the Windows C/C++ OutputDebugString() function no longer called. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #__23813_ (GitHub issue number if applicable) <!-- Either: --> - [x] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24184) <!-- Reviewable:end -->
|
We'll need to clean this up for non-windows builds: |
|
|
|
|
|
Superseded by #26196. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
angelortiz1007 commentedSep 11, 2019
•
edited by SimonSapin
In CInitOptions added the variable pub ptrfunc: Option<fn(*const c_char) -> bool> which is responsible for being assigned to an Option<> None, or to a function implemented in the C/C++ code. The C/C++ implemented function is a platform specific logger.
In addition, vslogger.rs::log() function was modified to call this C/C++ platform specific function - if implemented - and the Windows C/C++ OutputDebugString() function no longer called.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is