Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement raqote backend for 2D canvas rendering #24201
Merged
Conversation
|
I think we should merge these changes after squashing the bitshifting commit and rebasing. |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Sep 17, 2019
Implement raqote backend for 2D canvas rendering <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [ ] These changes fix (part of) #23431 <!-- Either: --> - [ ] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24201) <!-- Reviewable:end -->
|
|
|
Tidy failure in linux and windows error: attempt to shift left with overflow
--> components/canvas/raqote_backend.rs:636:27
|
636| let color: u32 = (self.color.alpha << 8 * 3 |
| ^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[deny(exceeding_bitshifts)]` on by default
error: attempt to shift left with overflow
--> components/canvas/raqote_backend.rs:637:13
|
637| self.color.red << 8 * 2 |
| ^^^^^^^^^^^^^^^^^^^^^^^
error: attempt to shift left with overflow
--> components/canvas/raqote_backend.rs:638:13
|
638| self.color.green << 8 * 1 |
| ^^^^^^^^^^^^^^^^^^^^^^^^^
error: aborting due to 3 previous errors
error: Could not compile `canvas`.
warning: build failed, waiting for other jobs to finish...the mac one failed with #23290 intermittent |
|
You'll need to cast those u8 values to u32 before shifting. |
|
Thanks, I'm already on it! Building takes some time since the rebase.. |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Sep 17, 2019
Implement raqote backend for 2D canvas rendering <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [ ] These changes fix (part of) #23431 <!-- Either: --> - [ ] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24201) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
pylbrecht commentedSep 12, 2019
•
edited by jdm
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is