Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate a few dependencies #24213
Update a few dependencies #24213
Conversation
highfive
commented
Sep 14, 2019
|
Heads up! This PR modifies the following files:
|
|
@bors-servo r+ |
|
|
Update a few dependencies <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24213) <!-- Reviewable:end -->
|
|
|
|
Fun stuff. I can't repro those PASS locally. Are they new intermittent ? |
|
@bors-servo retry
|
Update a few dependencies <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24213) <!-- Reviewable:end -->
|
|
|
Fine ! I'll update you then. No idea why they're not passing locally though |
|
I'm curious to see if the tests pass on macos as well: https://treeherder.allizom.org/#/jobs?repo=servo-auto&revision=6cb7126471197799338b1270d9de50c62f749655 |
|
Indeed, the tests only pass on Linux for some reason. |
|
Why does this need code changes ? |
|
The test result ini files need to be marked as passing on Linux and failing on other platforms. |
|
But CI was green everywhere ? |
|
The CI result I linked to was from before fb81101. |
|
That's a lie, they never got a chance to run and I linked to the wrong CI revision. Ok! |
|
|
Update a few dependencies <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24213) <!-- Reviewable:end -->
|
|
|
|
|
Eijebong commentedSep 14, 2019
•
edited by SimonSapin
This change is