Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update a few dependencies #24213

Closed
wants to merge 4 commits into from
Closed

Update a few dependencies #24213

wants to merge 4 commits into from

Conversation

@Eijebong
Copy link
Member

Eijebong commented Sep 14, 2019

This change is Reviewable

@highfive
Copy link

highfive commented Sep 14, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/Cargo.toml
  • @KiChjang: components/script/Cargo.toml
  • @emilio: components/style/Cargo.toml, components/layout/Cargo.toml
@jdm
Copy link
Member

jdm commented Sep 14, 2019

@bors-servo
Copy link
Contributor

bors-servo commented Sep 14, 2019

📌 Commit daa520e has been approved by jdm

bors-servo added a commit that referenced this pull request Sep 14, 2019
Update a few dependencies

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24213)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 14, 2019

Testing commit daa520e with merge d94f341...

@bors-servo
Copy link
Contributor

bors-servo commented Sep 14, 2019

💔 Test failed - linux-rel-css

@CYBAI
Copy link
Collaborator

CYBAI commented Sep 14, 2019

👀

{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": null, 
    "test": "/css/css-text/shaping/shaping-011.html", 
    "line": 64280, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": null, 
    "test": "/css/css-text/shaping/shaping-005.html", 
    "line": 64977, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": null, 
    "test": "/css/css-text/shaping/shaping-014.html", 
    "line": 65148, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": null, 
    "test": "/css/css-text/shaping/shaping-016.html", 
    "line": 65842, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": null, 
    "test": "/css/css-text/shaping/shaping-009.html", 
    "line": 66887, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": null, 
    "test": "/css/css-text/shaping/shaping-004.html", 
    "line": 69496, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": null, 
    "test": "/css/css-text/shaping/shaping-010.html", 
    "line": 70051, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": null, 
    "test": "/css/css-text/shaping/shaping-006.html", 
    "line": 76623, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": null, 
    "test": "/css/css-text/shaping/shaping-007.html", 
    "line": 100593, 
    "action": "test_result", 
    "expected": "FAIL"
}
@Eijebong
Copy link
Member Author

Eijebong commented Sep 14, 2019

Fun stuff. I can't repro those PASS locally. Are they new intermittent ?

@CYBAI
Copy link
Collaborator

CYBAI commented Sep 14, 2019

@bors-servo retry

  • let's wait and see 😆
@bors-servo
Copy link
Contributor

bors-servo commented Sep 14, 2019

Testing commit daa520e with merge f32af45...

bors-servo added a commit that referenced this pull request Sep 14, 2019
Update a few dependencies

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24213)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 14, 2019

💔 Test failed - linux-rel-css

@Eijebong
Copy link
Member Author

Eijebong commented Sep 14, 2019

Fine ! I'll update you then. No idea why they're not passing locally though

@jdm
Copy link
Member

jdm commented Sep 14, 2019

@jdm
Copy link
Member

jdm commented Sep 14, 2019

Indeed, the tests only pass on Linux for some reason.

@Eijebong
Copy link
Member Author

Eijebong commented Sep 25, 2019

Why does this need code changes ?

@jdm
Copy link
Member

jdm commented Sep 25, 2019

The test result ini files need to be marked as passing on Linux and failing on other platforms.

@Eijebong
Copy link
Member Author

Eijebong commented Sep 25, 2019

But CI was green everywhere ?

@jdm
Copy link
Member

jdm commented Sep 25, 2019

The CI result I linked to was from before fb81101.

@jdm
Copy link
Member

jdm commented Sep 25, 2019

That's a lie, they never got a chance to run and I linked to the wrong CI revision. Ok!
@bors-servo r+

@bors-servo
Copy link
Contributor

bors-servo commented Sep 25, 2019

📌 Commit fb81101 has been approved by jdm

bors-servo added a commit that referenced this pull request Sep 25, 2019
Update a few dependencies

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24213)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 25, 2019

Testing commit fb81101 with merge 49d9125...

@bors-servo
Copy link
Contributor

bors-servo commented Sep 25, 2019

💔 Test failed - linux-rel-css

@CYBAI
Copy link
Collaborator

CYBAI commented Sep 26, 2019

👀

{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": null, 
    "test": "/css/css-text/shaping/shaping-007.html", 
    "line": 78120, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": null, 
    "test": "/css/css-text/shaping/shaping-006.html", 
    "line": 85126, 
    "action": "test_result", 
    "expected": "FAIL"
}
@bors-servo
Copy link
Contributor

bors-servo commented Sep 28, 2019

The latest upstream changes (presumably #24308) made this pull request unmergeable. Please resolve the merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.