Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add webidl bindings for DOMStringList #24220

Merged
merged 1 commit into from Sep 18, 2019
Merged

add webidl bindings for DOMStringList #24220

merged 1 commit into from Sep 18, 2019

Conversation

@rasviitanen
Copy link
Contributor

rasviitanen commented Sep 16, 2019 •
edited by SimonSapin

To prepare for the implementation of IndexedDB a DOM interface for DOMStringList is added.

This change:

  • Adds a new IDL file for DOMStringList
  • Lists domstringlist.rs in mod.rs
  • Defines a new DOMStruct DOMStringList
  • Changes some test expectations related to DOMStringList

  • ./mach build -d does not report any errors

  • ./mach test-tidy does not report any errors

  • These changes fix #24208

  • These changes do not require tests because:
    We are not yet able to fully test the functions of DOMStringList in the WPT, because it is not possible to create an object of the type DOMStringList until e.g. indexeddb or location.ancestorOrigins is implemented.

This change is Reviewable
@highfive
Copy link

highfive commented Sep 16, 2019

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @avadacatavra (or someone else) soon.
@highfive
Copy link

highfive commented Sep 16, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/webidls/DOMStringList.webidl, components/script/dom/mod.rs, components/script/dom/domstringlist.rs
  • @KiChjang: components/script/dom/webidls/DOMStringList.webidl, components/script/dom/mod.rs, components/script/dom/domstringlist.rs
@rasviitanen rasviitanen force-pushed the rasviitanen:domstringlist branch from 15b161a to 92ad032 Sep 16, 2019
@jdm jdm assigned jdm and unassigned avadacatavra Sep 17, 2019
@jdm
jdm approved these changes Sep 17, 2019
View changes
@jdm
Copy link
Member

jdm commented Sep 17, 2019

@bors-servo try=wpt
bors-servo added a commit that referenced this pull request Sep 17, 2019
@bors-servo
Auto merge of #24220 - rasviitanen:domstringlist, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
1f991e8 
add webidl bindings for DOMStringList

<!-- Please describe your changes on the following line: -->
To prepare for the implementation of `IndexedDB` a DOM interface for `DOMStringList` is added.

This change:
* Adds a new IDL file for `DOMStringList`
* Lists `domstringlist.rs` in `mod.rs`
* Defines a new DOMStruct `DOMStringList`
* Changes some test expectations related to `DOMStringList`
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #24208

- [X] These changes do not require tests because:
We are not yet able to fully test the functions of `DOMStringList` in the WPT, because it is not possible to create an object of the type `DOMStringList` until e.g. `indexeddb` or `location.ancestorOrigins` is implemented.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24220)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 17, 2019

⌛ Trying commit 92ad032 with merge 1f991e8...
@bors-servo
Copy link
Contributor

bors-servo commented Sep 17, 2019

💔 Test failed - linux-rel-css
@jdm
Copy link
Member

jdm commented Sep 17, 2019

You will need to update tests/wpt/mozilla/tests/mozilla/interfaces.html and tests/wpt/mozilla/tests/mozilla/interfaces.worker.js to include the new interface.
@rasviitanen rasviitanen force-pushed the rasviitanen:domstringlist branch from 92ad032 to 51a5fea Sep 17, 2019
Rasmus Viitanen
add webidl bindings for DOMStringList
Loading status checks…
7e4e48c
@rasviitanen rasviitanen force-pushed the rasviitanen:domstringlist branch from 51a5fea to 7e4e48c Sep 17, 2019
@jdm
Copy link
Member

jdm commented Sep 18, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Sep 18, 2019

📌 Commit 7e4e48c has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Sep 18, 2019

⌛ Testing commit 7e4e48c with merge 2996af4...
bors-servo added a commit that referenced this pull request Sep 18, 2019
@bors-servo
Auto merge of #24220 - rasviitanen:domstringlist, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
2996af4 
add webidl bindings for DOMStringList

<!-- Please describe your changes on the following line: -->
To prepare for the implementation of `IndexedDB` a DOM interface for `DOMStringList` is added.

This change:
* Adds a new IDL file for `DOMStringList`
* Lists `domstringlist.rs` in `mod.rs`
* Defines a new DOMStruct `DOMStringList`
* Changes some test expectations related to `DOMStringList`
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #24208

- [X] These changes do not require tests because:
We are not yet able to fully test the functions of `DOMStringList` in the WPT, because it is not possible to create an object of the type `DOMStringList` until e.g. `indexeddb` or `location.ancestorOrigins` is implemented.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24220)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 18, 2019

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented Sep 18, 2019

@bors-servo retry

  • Network failure
@bors-servo
Copy link
Contributor

bors-servo commented Sep 18, 2019

💣 Failed to start rebuilding: Unknown error
@bors-servo
Copy link
Contributor

bors-servo commented Sep 18, 2019

⌛ Testing commit 7e4e48c with merge 7458570...
bors-servo added a commit that referenced this pull request Sep 18, 2019
@bors-servo
Auto merge of #24220 - rasviitanen:domstringlist, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
7458570 
add webidl bindings for DOMStringList

<!-- Please describe your changes on the following line: -->
To prepare for the implementation of `IndexedDB` a DOM interface for `DOMStringList` is added.

This change:
* Adds a new IDL file for `DOMStringList`
* Lists `domstringlist.rs` in `mod.rs`
* Defines a new DOMStruct `DOMStringList`
* Changes some test expectations related to `DOMStringList`
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #24208

- [X] These changes do not require tests because:
We are not yet able to fully test the functions of `DOMStringList` in the WPT, because it is not possible to create an object of the type `DOMStringList` until e.g. `indexeddb` or `location.ancestorOrigins` is implemented.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24220)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 18, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: jdm
Pushing 7458570 to master...
@bors-servo bors-servo merged commit 7e4e48c into servo:master Sep 18, 2019
3 checks passed
3 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
This was referenced Sep 18, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdm jdm

Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Implement DOMStringList
5 participants
@rasviitanen @highfive @jdm @bors-servo @avadacatavra
You can’t perform that action at this time.