Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update servo-media #24236

Merged
merged 1 commit into from Sep 19, 2019
Merged

Update servo-media #24236

merged 1 commit into from Sep 19, 2019

Conversation

@asajeffrey
Copy link
Member

asajeffrey commented Sep 18, 2019 •
edited by SimonSapin

Update the servo-media crate and its dependencies.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes do not require tests because it's updating a dependency

This change is Reviewable
@asajeffrey
Update servo-media
Loading status checks…
0384e15
@jdm
Copy link
Member

jdm commented Sep 19, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Sep 19, 2019

📌 Commit 0384e15 has been approved by jdm
@highfive highfive assigned jdm and unassigned nox Sep 19, 2019
@bors-servo
Copy link
Contributor

bors-servo commented Sep 19, 2019

⌛ Testing commit 0384e15 with merge 7b653ca...
bors-servo added a commit that referenced this pull request Sep 19, 2019
@bors-servo
Auto merge of #24236 - asajeffrey:mediaup, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
7b653ca 
Update servo-media

<!-- Please describe your changes on the following line: -->

Update the servo-media crate and its dependencies.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes do not require tests because it's updating a dependency

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24236)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 19, 2019

💔 Test failed - linux-rel-wpt
@CYBAI
Copy link
Collaborator

CYBAI commented Sep 19, 2019

@bors-servo retry

  • this looks like intermittent failure to me 🤔
  ▶ Unexpected subtest result in /css/cssom-view/offsetTopLeft-border-box.html:
  │ FAIL [expected PASS] container: 0
  │   → assert_equals: offsetTop expected 2 but got 0
  │ FAIL [expected PASS] container: 1
  │   → assert_equals: offsetTop expected 2 but got 0
  │ 
  │ onload/</<@http://web-platform.test:8000/css/cssom-view/offsetTopLeft-border-box.html:55:7
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1611:25
  │ test@http://web-platform.test:8000/resources/testharness.js:544:30
  │ onload/<@http://web-platform.test:8000/css/cssom-view/offsetTopLeft-border-box.html:53:5
  └ onload@http://web-platform.test:8000/css/cssom-view/offsetTopLeft-border-box.html:52:40
@bors-servo
Copy link
Contributor

bors-servo commented Sep 19, 2019

⚡ Previous build results for linux-rel-css, status-taskcluster are reusable. Rebuilding only linux-rel-wpt...
@asajeffrey
Copy link
Member Author

asajeffrey commented Sep 19, 2019

Yes, I tried and failed to find an appropriate issue.
@CYBAI
Copy link
Collaborator

CYBAI commented Sep 19, 2019

Yes, I tried and failed to find an appropriate issue.

Let me file one then :D
@CYBAI
Copy link
Collaborator

CYBAI commented Sep 19, 2019

#24237
@bors-servo
Copy link
Contributor

bors-servo commented Sep 19, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: jdm
Pushing 7b653ca to master...
@bors-servo bors-servo merged commit 0384e15 into servo:master Sep 19, 2019
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
Taskcluster (pull_request) TaskGroup: success
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Sep 19, 2019
Merged
3 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
A-content/media S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@asajeffrey @jdm @bors-servo @CYBAI @nox @highfive
You can’t perform that action at this time.