Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upHook up GST_DEBUG log to visual studio output #24255
Merged
Conversation
|
r? @jdm |
ferjm
force-pushed the
ferjm:gst.log.uwp
branch
2 times, most recently
from
6570186
to
58b13ef
|
@bors-servo r+ |
|
|
|
@bors-servo r- |
|
@bors-servo r=jdm |
|
|
bors-servo
added a commit
that referenced
this pull request
Sep 24, 2019
Hook up GST_DEBUG log to visual studio output - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #23700 <strike>Depends on https://github.com/servo/media/pull/312</strike> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24255) <!-- Reviewable:end -->
|
|
| use gstreamer::{debug_add_log_function, debug_remove_default_log_function, DebugLevel}; | ||
|
|
||
| debug_remove_default_log_function(); | ||
| debug_add_log_function(|cat, level, file, function, line, _, message| { |
This comment has been minimized.
This comment has been minimized.
sdroege
Sep 30, 2019
You probably also want to include the name of the object in the logs somewhere. The _ parameter :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ferjm commentedSep 20, 2019
•
edited
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsDepends on servo/media#312This change is