Update to UWP compatible OpenSSL build. #24257

jdm · 2019-09-20T20:25:36Z

This uses OpenSSL binaries built from https://github.com/servo/openssl-windows-build which yield no more WACK violations.

./mach build -d does not report any errors
./mach test-tidy does not report any errors
These changes fix #24138
These changes do not require tests because no CI for WACK or windows yet.

This change is

highfive · 2019-09-20T20:25:41Z

Heads up! This PR modifies the following files:

@wafflespeanut: python/servo/packages.py

jdm · 2019-09-21T15:40:03Z

r? @paulrouget

jdm · 2019-09-23T17:13:01Z

@bors-servo r+

bors-servo · 2019-09-23T17:13:03Z

📌 Commit 5de8578 has been approved by jdm

bors-servo · 2019-09-23T17:20:15Z

⌛ Testing commit 5de8578 with merge 2c9a597...


        Auto merge of #24257 - servo:jdm-patch-56, r=jdm

Update to UWP compatible OpenSSL build. This uses OpenSSL binaries built from https://github.com/servo/openssl-windows-build which yield no more WACK violations. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #24138 - [x] These changes do not require tests because no CI for WACK or windows yet.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24257)

bors-servo · 2019-09-23T17:47:48Z

💔 Test failed - linux-rel-css

jdm · 2019-09-23T17:56:12Z

@bors-servo retry

bors-servo · 2019-09-23T17:56:58Z

⌛ Testing commit 5de8578 with merge d49a9c4...


        Auto merge of #24257 - servo:jdm-patch-56, r=jdm

Update to UWP compatible OpenSSL build. This uses OpenSSL binaries built from https://github.com/servo/openssl-windows-build which yield no more WACK violations. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #24138 - [x] These changes do not require tests because no CI for WACK or windows yet.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24257)

bors-servo · 2019-09-23T18:24:42Z

💔 Test failed - linux-rel-css

jdm · 2019-09-23T18:31:54Z

@bors-servo retry

#20271

bors-servo · 2019-09-24T03:20:41Z

⌛ Testing commit 5de8578 with merge b694c14...


        Auto merge of #24257 - servo:jdm-patch-56, r=jdm

Update to UWP compatible OpenSSL build. This uses OpenSSL binaries built from https://github.com/servo/openssl-windows-build which yield no more WACK violations. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #24138 - [x] These changes do not require tests because no CI for WACK or windows yet.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24257)

jdm · 2019-10-02T17:23:55Z

@bors-servo r+

bors-servo · 2019-10-02T17:23:55Z

📌 Commit 7332adc has been approved by jdm

bors-servo · 2019-10-02T18:47:30Z

☔ The latest upstream changes (presumably #24343) made this pull request unmergeable. Please resolve the merge conflicts.


        Update to UWP compatible OpenSSL build.

jdm · 2019-10-02T19:01:15Z

@bors-servo r+

bors-servo · 2019-10-02T19:01:17Z

📌 Commit 96302ba has been approved by jdm

bors-servo · 2019-10-02T20:00:42Z

⌛ Testing commit 96302ba with merge 66035b0...


        Auto merge of #24257 - servo:jdm-patch-56, r=jdm

Update to UWP compatible OpenSSL build. This uses OpenSSL binaries built from https://github.com/servo/openssl-windows-build which yield no more WACK violations. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #24138 - [x] These changes do not require tests because no CI for WACK or windows yet.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24257)

bors-servo · 2019-10-02T21:38:41Z

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: jdm
Pushing 66035b0 to master...


        Auto merge of #24352 - servo:jdm-patch-28, r=paulrouget

Use correct OpenSSL arch in UWP builds. This is a followup from #24257. I forgot to run the UWP WACK tests after making my changes, or I would have noticed that the wrong DLLs were being selected for UWP builds.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24352)


        Auto merge of #24352 - servo:jdm-patch-28, r=paulrouget

Use correct OpenSSL arch in UWP builds. This is a followup from #24257. I forgot to run the UWP WACK tests after making my changes, or I would have noticed that the wrong DLLs were being selected for UWP builds.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24352)


        Auto merge of #24352 - servo:jdm-patch-28, r=paulrouget

Use correct OpenSSL arch in UWP builds. This is a followup from #24257. I forgot to run the UWP WACK tests after making my changes, or I would have noticed that the wrong DLLs were being selected for UWP builds.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24352)


        Auto merge of #24352 - servo:jdm-patch-28, r=paulrouget

Use correct OpenSSL arch in UWP builds. This is a followup from #24257. I forgot to run the UWP WACK tests after making my changes, or I would have noticed that the wrong DLLs were being selected for UWP builds.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24352)


        Auto merge of #24352 - servo:jdm-patch-28, r=paulrouget

Use correct OpenSSL arch in UWP builds. This is a followup from #24257. I forgot to run the UWP WACK tests after making my changes, or I would have noticed that the wrong DLLs were being selected for UWP builds.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24352)

highfive assigned avadacatavra Sep 20, 2019

highfive added the S-awaiting-review label Sep 20, 2019

highfive assigned paulrouget and unassigned avadacatavra Sep 21, 2019

highfive assigned jdm and unassigned paulrouget Sep 23, 2019

highfive added S-awaiting-merge and removed S-awaiting-review labels Sep 23, 2019

highfive added S-tests-failed and removed S-awaiting-merge labels Sep 23, 2019

highfive added S-awaiting-merge and removed S-tests-failed labels Sep 23, 2019

highfive added S-tests-failed and removed S-awaiting-merge labels Sep 23, 2019

highfive added S-awaiting-merge and removed S-tests-failed labels Sep 24, 2019

jdm force-pushed the jdm-patch-56 branch from 5de8578 to 7332adc Oct 2, 2019

highfive added S-awaiting-review and removed S-tests-failed labels Oct 2, 2019

highfive added S-awaiting-merge and removed S-awaiting-review labels Oct 2, 2019

highfive added S-needs-rebase and removed S-awaiting-merge labels Oct 2, 2019

Update to UWP compatible OpenSSL build.

Loading status checks…

96302ba

jdm force-pushed the jdm-patch-56 branch from 7332adc to 96302ba Oct 2, 2019

highfive added the S-awaiting-review label Oct 2, 2019

highfive added S-awaiting-merge and removed S-awaiting-review S-needs-rebase labels Oct 2, 2019

bors-servo merged commit 96302ba into master Oct 2, 2019
3 checks passed

3 checks passed

Taskcluster (pull_request) TaskGroup: success
Details

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

homu Test successful
Details

highfive removed the S-awaiting-merge label Oct 2, 2019

jdm mentioned this pull request Oct 3, 2019

Use correct OpenSSL arch in UWP builds. #24352

Merged

SimonSapin deleted the jdm-patch-56 branch Dec 12, 2019

servo / servo

Update to UWP compatible OpenSSL build. #24257

Update to UWP compatible OpenSSL build. #24257

jdm commented Sep 20, 2019 •

edited by SimonSapin

highfive commented Sep 20, 2019

jdm commented Sep 21, 2019

jdm commented Sep 23, 2019

bors-servo commented Sep 23, 2019

bors-servo commented Sep 23, 2019

bors-servo commented Sep 23, 2019

jdm commented Sep 23, 2019

bors-servo commented Sep 23, 2019

bors-servo commented Sep 23, 2019

jdm commented Sep 23, 2019

bors-servo commented Sep 24, 2019

jdm commented Oct 2, 2019

bors-servo commented Oct 2, 2019

bors-servo commented Oct 2, 2019

jdm commented Oct 2, 2019

bors-servo commented Oct 2, 2019

bors-servo commented Oct 2, 2019

bors-servo commented Oct 2, 2019

servo / servo

Join GitHub today

Update to UWP compatible OpenSSL build. #24257

Update to UWP compatible OpenSSL build. #24257

Conversation

jdm commented Sep 20, 2019 • edited by SimonSapin

highfive commented Sep 20, 2019

jdm commented Sep 21, 2019

jdm commented Sep 23, 2019

bors-servo commented Sep 23, 2019

bors-servo commented Sep 23, 2019

bors-servo commented Sep 23, 2019

jdm commented Sep 23, 2019

bors-servo commented Sep 23, 2019

bors-servo commented Sep 23, 2019

jdm commented Sep 23, 2019

bors-servo commented Sep 24, 2019

jdm commented Oct 2, 2019

bors-servo commented Oct 2, 2019

bors-servo commented Oct 2, 2019

jdm commented Oct 2, 2019

bors-servo commented Oct 2, 2019

bors-servo commented Oct 2, 2019

bors-servo commented Oct 2, 2019

jdm commented Sep 20, 2019 •

edited by SimonSapin