Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upwebxr and offscreen gl context update #24259
Merged
+538
−10
Conversation
|
@bors-servo try=wpt |
bors-servo
added a commit
that referenced
this pull request
Sep 21, 2019
webxr and offscreen gl context update <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24259) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Sep 21, 2019
webxr and offscreen gl context update <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24259) <!-- Reviewable:end -->
|
|
|
|
I recommend grabbing https://build.servo.org/builders/linux-rel-css/builds/13459/steps/test/logs/test-wpt.log/text and https://build.servo.org/builders/linux-rel-wpt/builds/13520/steps/test__1/logs/test-wpt.log/text and running |
|
@bors-servo try |
bors-servo
added a commit
that referenced
this pull request
Sep 24, 2019
webxr and offscreen gl context update <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24259) <!-- Reviewable:end -->
|
|
|
The test result update commit didn't include any webgl tests for some reason. |
|
I've included only the changes that, I believe, are related to #21132 |
|
@bors-servo try=wpt |
bors-servo
added a commit
that referenced
this pull request
Sep 24, 2019
webxr and offscreen gl context update <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24259) <!-- Reviewable:end -->
|
Running the tests manually returns OK. When ran as part of |
|
I expect this to pass the wpt tests. But I don't know why we have new timeouts. @bors-servo try=wpt |
bors-servo
added a commit
that referenced
this pull request
Sep 25, 2019
webxr and offscreen gl context update <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24259) <!-- Reviewable:end -->
|
|
|
Oh great... now it doesn't timeout (both times it had a long timeout). |
|
In short, |
|
@bors-servo try=wpt |
bors-servo
added a commit
that referenced
this pull request
Sep 25, 2019
webxr and offscreen gl context update <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24259) <!-- Reviewable:end -->
|
|
|
Sigh - the errorsummary log formatter we're using doesn't support the multiple results yet. I've filed #24295 so we can move on. |
|
|
bors-servo
added a commit
that referenced
this pull request
Sep 25, 2019
webxr and offscreen gl context update <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24259) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
paulrouget commentedSep 21, 2019
•
edited by SimonSapin
This change is