Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete macOS build instructions #24279

Merged
merged 2 commits into from Sep 25, 2019
Merged

Remove obsolete macOS build instructions #24279

merged 2 commits into from Sep 25, 2019

Conversation

@nox
Copy link
Member

nox commented Sep 24, 2019 •
edited by SimonSapin

openssl is already installed through the Brewfile, and libffi needs no
environment variable anymore now that glib was fixed.

Homebrew/homebrew-core#44446

This change is Reviewable
@nox
Remove obsolete macOS build instructions
Loading status checks…
15e5bb7 
openssl is already installed through the Brewfile, and libffi needs no
environment variable anymore now that glib was fixed.

Homebrew/homebrew-core#44446
@nox nox assigned jdm Sep 24, 2019
@paulrouget
Copy link
Contributor

paulrouget commented Sep 24, 2019

libffi needs no environment variable anymore now that glib was fixed

So brew upgrade libffi and unsetting the env variable would work?
@ferjm
Copy link
Member

ferjm commented Sep 24, 2019

Can this be removed as well then?
@nox
Copy link
Member Author

nox commented Sep 24, 2019

So brew upgrade libffi and unsetting the env variable would work?

brew upgrade glib, it was not a libffi issue.

Can this be removed as well then?

Yes.
@nox
Don't set PKG_CONFIG_PATH anymore
Loading status checks…
768af85 
glib will find libffi on its own in its opt path now.
@nox
Copy link
Member Author

nox commented Sep 24, 2019

I pushed a commit that removes the bits referenced by @ferjm.
@jdm
Copy link
Member

jdm commented Sep 24, 2019

We will need to log into the mac builders and upgrade their glib packages before this merges.
@paulrouget
Copy link
Contributor

paulrouget commented Sep 24, 2019

Works here.
@nox
Copy link
Member Author

nox commented Sep 24, 2019

We will need to log into the mac builders and upgrade their glib packages before this merges.

Are you on it? I don't even know how to log into that hah.
@jdm
Copy link
Member

jdm commented Sep 24, 2019

Yes, I will do that today.
@jdm
Copy link
Member

jdm commented Sep 25, 2019

Builders upgraded.
@jdm
Copy link
Member

jdm commented Sep 25, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Sep 25, 2019

📌 Commit 768af85 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Sep 25, 2019

🌲 The tree is currently closed for pull requests below priority 10, this pull request will be tested once the tree is reopened
@bors-servo
Copy link
Contributor

bors-servo commented Sep 25, 2019

⌛ Testing commit 768af85 with merge 57961bd...
bors-servo added a commit that referenced this pull request Sep 25, 2019
@bors-servo
Auto merge of #24279 - servo:macos-build, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
57961bd 
Remove obsolete macOS build instructions

openssl is already installed through the Brewfile, and libffi needs no
environment variable anymore now that glib was fixed.

Homebrew/homebrew-core#44446

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24279)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 25, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: jdm
Pushing 57961bd to master...
@bors-servo bors-servo merged commit 768af85 into master Sep 25, 2019
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
Taskcluster (pull_request) TaskGroup: success
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Sep 25, 2019
Closed
3 of 3 tasks complete
@SimonSapin SimonSapin deleted the macos-build branch Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@nox @paulrouget @ferjm @jdm @bors-servo @highfive
You can’t perform that action at this time.