Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to rustc 1.39.0-nightly (66bf391c3 2019-09-23) #24283

Merged
merged 2 commits into from Sep 25, 2019
Merged

Upgrade to rustc 1.39.0-nightly (66bf391c3 2019-09-23) #24283

merged 2 commits into from Sep 25, 2019

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented Sep 24, 2019 •
edited

This change is Reviewable
@highfive
Copy link

highfive commented Sep 24, 2019

Heads up! This PR modifies the following files:

  • @emilio: components/style/Cargo.toml, components/layout/inline.rs
@highfive
Copy link

highfive commented Sep 24, 2019

warning Warning warning

  • These commits modify style and layout code, but no tests are modified. Please consider adding a test!
@jdm
jdm approved these changes Sep 24, 2019
View changes
@jdm
Copy link
Member

jdm commented Sep 24, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Sep 24, 2019

📌 Commit 822b2b7 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Sep 25, 2019

☔ The latest upstream changes (presumably #24259) made this pull request unmergeable. Please resolve the merge conflicts.
SimonSapin added 2 commits Sep 24, 2019
@SimonSapin
Update to bindgen 0.51
f3fb446
@SimonSapin
Upgrade to rustc 1.39.0-nightly (66bf391c3 2019-09-23)
Loading status checks…
d696070
@SimonSapin SimonSapin force-pushed the rustup branch from 822b2b7 to d696070 Sep 25, 2019
@SimonSapin
Copy link
Member Author

SimonSapin commented Sep 25, 2019

@bors-servo r=jdm
@bors-servo
Copy link
Contributor

bors-servo commented Sep 25, 2019

📌 Commit d696070 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Sep 25, 2019

⌛ Testing commit d696070 with merge 5518951...
bors-servo added a commit that referenced this pull request Sep 25, 2019
@bors-servo
Auto merge of #24283 - servo:rustup, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5518951 
Upgrade to rustc 1.39.0-nightly (66bf391c3 2019-09-23)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24283)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 25, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: jdm
Pushing 5518951 to master...
@bors-servo bors-servo merged commit d696070 into master Sep 25, 2019
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
Taskcluster (pull_request) TaskGroup: success
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdm jdm

Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@SimonSapin @highfive @jdm @bors-servo
You can’t perform that action at this time.