Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update a bunch of stuff to syn 1 #24308

Merged
merged 5 commits into from Sep 28, 2019
Merged

Update a bunch of stuff to syn 1 #24308

merged 5 commits into from Sep 28, 2019

Conversation

@nox
Copy link
Member

nox commented Sep 27, 2019 •
edited by SimonSapin

This updates a lot of our crates to syn 1. Not all of them, but syn 1 was already in tree so it doesn't matter much either way.

This change is Reviewable
nox added 3 commits Sep 27, 2019
@nox
Restrict syn features for in-tree components
423cb12
@nox
Update a bunch of dependencies to versions using syn 1
2d823d7
@nox
Bump all in-tree components to syn 1
99ef781
@highfive
Copy link

highfive commented Sep 27, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/Cargo.toml
  • @KiChjang: components/script/Cargo.toml
  • @emilio: components/style/Cargo.toml, components/layout/Cargo.toml
@SimonSapin
SimonSapin approved these changes Sep 27, 2019
View changes
components/to_shmem_derive/Cargo.toml
@@ -14,5 +14,5 @@ darling = "0.9"
derive_common = { path = "../derive_common" }
proc-macro2 = "0.4"
quote = "0.6"
syn = { version = "0.15", features = ["visit"] }

This comment has been minimized.

Sign in to view
@SimonSapin

SimonSapin Sep 27, 2019

Member

Have you checked (for example in the HTML report for -Z timings) that this actually disables some feature? Since Cargo takes the union of features requested by all dependent crates, this could have no effect at all. And conversely, if this patch is wrong the build might not break.

This comment has been minimized.

Sign in to view
@nox

nox Sep 27, 2019

Author Member

Have you checked (for example in the HTML report for -Z timings) that this actually disables some feature? Since Cargo takes the union of features requested by all dependent crates, this could have no effect at all. And conversely, if this patch is wrong the build might not break.

Some other crates actually need visit in the graph, I just know to_shmem_derive doesn't need it (through git grep -w visit components/to_shmem_derive).
@SimonSapin
Copy link
Member

SimonSapin commented Sep 27, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Sep 27, 2019

📌 Commit 47e5193 has been approved by SimonSapin
@highfive highfive assigned SimonSapin and unassigned Manishearth Sep 27, 2019
nox added 2 commits Sep 27, 2019
@nox
Remove explicit dependency on serde_derive
1b57558
@nox
Update html5ever to 0.24
Loading status checks…
bceecdd
@nox nox force-pushed the synful branch from 47e5193 to bceecdd Sep 27, 2019
@nox
Copy link
Member Author

nox commented Sep 27, 2019

I broke unit tests in servo_config.

@bors-servo r=SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented Sep 27, 2019

📌 Commit bceecdd has been approved by SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented Sep 27, 2019

⌛ Testing commit bceecdd with merge 9c2fc22...
bors-servo added a commit that referenced this pull request Sep 27, 2019
@bors-servo
Auto merge of #24308 - servo:synful, r=SimonSapin
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9c2fc22 
Update a bunch of stuff to syn 1

This updates a lot of our crates to syn 1. Not all of them, but syn 1 was already in tree so it doesn't matter much either way.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24308)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 27, 2019

💔 Test failed - linux-rel-wpt
@nox
Copy link
Member Author

nox commented Sep 27, 2019

@bors-servo retry #24311
@bors-servo
Copy link
Contributor

bors-servo commented Sep 27, 2019

⌛ Testing commit bceecdd with merge 2550151...
bors-servo added a commit that referenced this pull request Sep 27, 2019
@bors-servo
Auto merge of #24308 - servo:synful, r=SimonSapin
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
2550151 
Update a bunch of stuff to syn 1

This updates a lot of our crates to syn 1. Not all of them, but syn 1 was already in tree so it doesn't matter much either way.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24308)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 28, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: SimonSapin
Pushing 2550151 to master...
@bors-servo bors-servo merged commit bceecdd into master Sep 28, 2019
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
Taskcluster (pull_request) TaskGroup: success
Details
homu Test successful
Details
This was referenced Sep 28, 2019
Closed
Closed
@SimonSapin SimonSapin deleted the synful branch Sep 30, 2019
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Oct 9, 2019
@emilio
Bug 1587368 - Cherry-pick updates towards syn 1.
5a6d7ed 
From: servo/servo#24308
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 9, 2019
@marco-c
Bug 1587368 - Cherry-pick updates towards syn 1.
5ce095f 
From: servo/servo#24308

UltraBlame original commit: 713dee70307db8ddaf7f591207e243a3e5e407da
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 9, 2019
@marco-c
Bug 1587368 - Cherry-pick updates towards syn 1.
76bf206 
From: servo/servo#24308

UltraBlame original commit: 713dee70307db8ddaf7f591207e243a3e5e407da
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 9, 2019
@marco-c
Bug 1587368 - Cherry-pick updates towards syn 1.
bc2a844 
From: servo/servo#24308

UltraBlame original commit: 713dee70307db8ddaf7f591207e243a3e5e407da
xeonchen pushed a commit to xeonchen/gecko that referenced this pull request Oct 10, 2019
@emilio
Bug 1587368 - Cherry-pick updates towards syn 1.
131adb1 
From: servo/servo#24308
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonSapin SimonSapin

Assignees

@SimonSapin SimonSapin

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@nox @highfive @SimonSapin @bors-servo @Manishearth
You can’t perform that action at this time.