Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign updon't send progress event for empty blob #24312
Merged
Conversation
highfive
commented
Sep 28, 2019
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @jdm (or someone else) soon. |
highfive
commented
Sep 28, 2019
|
Heads up! This PR modifies the following files:
|
| @@ -1,9 +1,9 @@ | |||
| [filereader_events.any.html] | |||
| [events are dispatched in the correct order for an empty blob] | |||
| expected: FAIL | |||
| expected: PASS | |||
This comment has been minimized.
This comment has been minimized.
SiddharthaMishra
force-pushed the
SiddharthaMishra:master
branch
from
aeba242
to
ef3f7c2
components/script/dom/filereader.rs
Outdated
| @@ -491,7 +497,7 @@ fn perform_annotated_read_operation( | |||
| let task = FileReadingTask::ProcessRead(filereader.clone(), gen_id); | |||
| task_source.queue_with_canceller(task, &canceller).unwrap(); | |||
|
|
|||
| let task = FileReadingTask::ProcessReadData(filereader.clone(), gen_id); | |||
| let task = FileReadingTask::ProcessReadData(filereader.clone(), gen_id, blob_contents.clone()); | |||
This comment has been minimized.
This comment has been minimized.
jdm
Sep 30, 2019
Member
I suggest instead of passing the blob_contents to this task, we check whether blob_contents is empty and skip it entirely. This will make many of the other changes in this PR unnecessary.
SiddharthaMishra
force-pushed the
SiddharthaMishra:master
branch
from
ef3f7c2
to
fbf7293
|
@bors-servo try=wpt |
bors-servo
added a commit
that referenced
this pull request
Oct 10, 2019
don't send progress event for empty blob <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #24289 (GitHub issue number if applicable) <!-- Either: --> - [X] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24312) <!-- Reviewable:end -->
|
|
|
Hooray, new passing tests! You can remove this file and add the change to the existing commit in this PR. |
SiddharthaMishra
force-pushed the
SiddharthaMishra:master
branch
from
fbf7293
to
6735b68
highfive
added
S-awaiting-review
and removed
S-tests-failed
S-needs-code-changes
labels
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 10, 2019
don't send progress event for empty blob <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #24289 (GitHub issue number if applicable) <!-- Either: --> - [X] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24312) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Oct 10, 2019
don't send progress event for empty blob <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #24289 (GitHub issue number if applicable) <!-- Either: --> - [X] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24312) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
SiddharthaMishra commentedSep 28, 2019
•
edited
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is