Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to navigate with the keyboard in the webxr glwindow view #24324

Merged
merged 2 commits into from Oct 1, 2019

Conversation

@paulrouget
Copy link
Contributor

paulrouget commented Sep 30, 2019

The glwindow is not interactive. With this PR we can use the arrow key to look up, down, right and left.

This will make debugging a lot easier.


This change is Reviewable

@paulrouget
Copy link
Contributor Author

paulrouget commented Sep 30, 2019

This was not as easy as I expected. We need to process events for all windows, but the glutin app never had any reference to the xr' glwindow.

Managing multiple windows will be necessary in the future, so this work is not useless, but it's not complete either (see inline comment about multiple windows vs. multiple browser).

bors-servo added a commit to servo/webxr that referenced this pull request Sep 30, 2019
glwindow: make it possible to rotate

Necessary for servo/servo#24324
@paulrouget paulrouget force-pushed the paulrouget:glwindow_keyboard branch from acfe635 to 42e095a Sep 30, 2019
@asajeffrey
Copy link
Member

asajeffrey commented Sep 30, 2019

I guess there's a question about which bits of logic should live in servo and which in the glwindow. If we want to put everything in servo this looks fine to me. We'll need most of it at some point when we handle multliple windows properly. You can r=me.

@paulrouget paulrouget force-pushed the paulrouget:glwindow_keyboard branch 2 times, most recently from 7831c01 to 3711ea9 Sep 30, 2019
@paulrouget
Copy link
Contributor Author

paulrouget commented Sep 30, 2019

@bors-servo try=wpt

@bors-servo
Copy link
Contributor

bors-servo commented Sep 30, 2019

Trying commit 3711ea9 with merge 81af4f2...

bors-servo added a commit that referenced this pull request Sep 30, 2019
Make it possible to navigate with the keyboard in the webxr glwindow view

The glwindow is not interactive. With this PR we can use the arrow key to look up, down, right and left.

This will make debugging a lot easier.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24324)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 30, 2019

💔 Test failed - linux-rel-css

@jdm
Copy link
Member

jdm commented Sep 30, 2019

fn id(&self) -> Option<glutin::WindowId> {
None
}

@paulrouget paulrouget force-pushed the paulrouget:glwindow_keyboard branch from 3711ea9 to e1bc980 Oct 1, 2019
@highfive highfive removed the S-tests-failed label Oct 1, 2019
@paulrouget
Copy link
Contributor Author

paulrouget commented Oct 1, 2019

@bors-servo try=wpt

@bors-servo
Copy link
Contributor

bors-servo commented Oct 1, 2019

Trying commit e1bc980 with merge 617f418...

bors-servo added a commit that referenced this pull request Oct 1, 2019
Make it possible to navigate with the keyboard in the webxr glwindow view

The glwindow is not interactive. With this PR we can use the arrow key to look up, down, right and left.

This will make debugging a lot easier.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24324)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 1, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
State: approved= try=True

@paulrouget
Copy link
Contributor Author

paulrouget commented Oct 1, 2019

@bors-servo r=asajeffrey

@bors-servo
Copy link
Contributor

bors-servo commented Oct 1, 2019

📌 Commit e1bc980 has been approved by asajeffrey

@bors-servo
Copy link
Contributor

bors-servo commented Oct 1, 2019

Testing commit e1bc980 with merge 61bf3ac...

bors-servo added a commit that referenced this pull request Oct 1, 2019
Make it possible to navigate with the keyboard in the webxr glwindow view

The glwindow is not interactive. With this PR we can use the arrow key to look up, down, right and left.

This will make debugging a lot easier.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24324)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 1, 2019

💔 Test failed - status-taskcluster

@CYBAI
Copy link
Collaborator

CYBAI commented Oct 1, 2019

Failure in magicleap build:

error[E0053]: method `wait_for_animation_frame` has an incompatible type for trait
   --> /Users/worker/.cargo/git/checkouts/webxr-702fa5244eec1e69/13a57d7/webxr/magicleap/mod.rs:383:5
    |
383 |     fn wait_for_animation_frame(&mut self) -> Frame {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected enum `std::option::Option`, found struct `webxr_api::frame::Frame`
    |
    = note: expected type `fn(&mut magicleap::MagicLeapDevice) -> std::option::Option<webxr_api::frame::Frame>`
               found type `fn(&mut magicleap::MagicLeapDevice) -> webxr_api::frame::Frame`
@paulrouget
Copy link
Contributor Author

paulrouget commented Oct 1, 2019

@paulrouget paulrouget force-pushed the paulrouget:glwindow_keyboard branch from e1bc980 to e65f1c9 Oct 1, 2019
@paulrouget
Copy link
Contributor Author

paulrouget commented Oct 1, 2019

@bors-servo r=asajeffrey

@bors-servo
Copy link
Contributor

bors-servo commented Oct 1, 2019

📌 Commit e65f1c9 has been approved by asajeffrey

@bors-servo
Copy link
Contributor

bors-servo commented Oct 1, 2019

Testing commit e65f1c9 with merge ad1d003...

bors-servo added a commit that referenced this pull request Oct 1, 2019
Make it possible to navigate with the keyboard in the webxr glwindow view

The glwindow is not interactive. With this PR we can use the arrow key to look up, down, right and left.

This will make debugging a lot easier.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24324)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 1, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: asajeffrey
Pushing ad1d003 to master...

@bors-servo bors-servo merged commit e65f1c9 into servo:master Oct 1, 2019
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
Taskcluster (pull_request) TaskGroup: success
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.