Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMake it possible to navigate with the keyboard in the webxr glwindow view #24324
Conversation
|
This was not as easy as I expected. We need to process events for all windows, but the glutin app never had any reference to the xr' glwindow. Managing multiple windows will be necessary in the future, so this work is not useless, but it's not complete either (see inline comment about multiple windows vs. multiple browser). |
glwindow: make it possible to rotate Necessary for servo/servo#24324
acfe635
to
42e095a
|
I guess there's a question about which bits of logic should live in servo and which in the glwindow. If we want to put everything in servo this looks fine to me. We'll need most of it at some point when we handle multliple windows properly. You can r=me. |
7831c01
to
3711ea9
|
@bors-servo try=wpt |
Make it possible to navigate with the keyboard in the webxr glwindow view The glwindow is not interactive. With this PR we can use the arrow key to look up, down, right and left. This will make debugging a lot easier. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24324) <!-- Reviewable:end -->
|
|
|
servo/ports/glutin/headless_window.rs Lines 135 to 137 in 3711ea9 |
|
@bors-servo try=wpt |
Make it possible to navigate with the keyboard in the webxr glwindow view The glwindow is not interactive. With this PR we can use the arrow key to look up, down, right and left. This will make debugging a lot easier. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24324) <!-- Reviewable:end -->
|
|
|
@bors-servo r=asajeffrey |
|
|
Make it possible to navigate with the keyboard in the webxr glwindow view The glwindow is not interactive. With this PR we can use the arrow key to look up, down, right and left. This will make debugging a lot easier. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24324) <!-- Reviewable:end -->
|
|
|
Failure in magicleap build:
|
|
@bors-servo r=asajeffrey |
|
|
Make it possible to navigate with the keyboard in the webxr glwindow view The glwindow is not interactive. With this PR we can use the arrow key to look up, down, right and left. This will make debugging a lot easier. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24324) <!-- Reviewable:end -->
|
|
paulrouget commentedSep 30, 2019
•
edited by SimonSapin
The glwindow is not interactive. With this PR we can use the arrow key to look up, down, right and left.
This will make debugging a lot easier.
This change is