Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused dependencies #24335

Merged
merged 1 commit into from Oct 2, 2019
Merged

Remove unused dependencies #24335

merged 1 commit into from Oct 2, 2019

Conversation

@sinkuu
Copy link
Contributor

sinkuu commented Oct 1, 2019 •
edited by SimonSapin

Removes unused crates from Cargo.toml to (possibly) shorten build time.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #___ (GitHub issue number if applicable)
  • There are tests for these changes OR
  • These changes do not require tests because no semantic changes

This change is Reviewable
@highfive
Copy link

highfive commented Oct 1, 2019

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @nox (or someone else) soon.
@highfive
Copy link

highfive commented Oct 1, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/constellation/Cargo.toml, components/script/Cargo.toml, components/webdriver_server/Cargo.toml
  • @cbrewster: components/constellation/Cargo.toml
  • @jgraham: components/webdriver_server/Cargo.toml
  • @KiChjang: components/script/Cargo.toml, components/net/Cargo.toml, components/net_traits/Cargo.toml
  • @emilio: components/layout/Cargo.toml
@sinkuu
Remove unused dependencies
Loading status checks…
b228d27
@sinkuu sinkuu force-pushed the sinkuu:unuesd_deps branch from 1034fb1 to b228d27 Oct 1, 2019
@SimonSapin
Copy link
Member

SimonSapin commented Oct 1, 2019

Nice! Did you manually look at each Cargo.toml file and corresponding code, or was there a way to semi-automate this?

Either way:

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Oct 1, 2019

📌 Commit b228d27 has been approved by SimonSapin
@highfive highfive assigned SimonSapin and unassigned nox Oct 1, 2019
@sinkuu
Copy link
Contributor Author

sinkuu commented Oct 1, 2019

@SimonSapin A script that runs rg -qw $dependency for each dependency. https://gist.github.com/sinkuu/8083240257c485c9f928744b41bbac98
@nox
Copy link
Member

nox commented Oct 1, 2019

@bors-servo
Copy link
Contributor

bors-servo commented Oct 1, 2019

⌛ Testing commit b228d27 with merge 9a40144...
bors-servo added a commit that referenced this pull request Oct 1, 2019
@bors-servo
Auto merge of #24335 - sinkuu:unuesd_deps, r=SimonSapin
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9a40144 
Remove unused dependencies

<!-- Please describe your changes on the following line: -->
Removes unused crates from `Cargo.toml` to (possibly) shorten build time.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because no semantic changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24335)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 2, 2019

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented Oct 2, 2019

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Oct 2, 2019

⌛ Testing commit b228d27 with merge d70d270...
bors-servo added a commit that referenced this pull request Oct 2, 2019
@bors-servo
Auto merge of #24335 - sinkuu:unuesd_deps, r=SimonSapin
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d70d270 
Remove unused dependencies

<!-- Please describe your changes on the following line: -->
Removes unused crates from `Cargo.toml` to (possibly) shorten build time.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because no semantic changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24335)
<!-- Reviewable:end -->
@sinkuu
Copy link
Contributor Author

sinkuu commented Oct 2, 2019

@nox No, the script uses cargo_metadata, which is independent from actual file formats.
@bors-servo
Copy link
Contributor

bors-servo commented Oct 2, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: SimonSapin
Pushing d70d270 to master...
@bors-servo bors-servo merged commit b228d27 into servo:master Oct 2, 2019
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
Taskcluster (pull_request) TaskGroup: success
Details
homu Test successful
Details
This was referenced Oct 2, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SimonSapin SimonSapin

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@sinkuu @highfive @SimonSapin @bors-servo @nox @jdm
You can’t perform that action at this time.