Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync WPT with upstream (02-10-2019) #24346

Closed
wants to merge 1 commit into from
Closed

Sync WPT with upstream (02-10-2019) #24346

wants to merge 1 commit into from
+2,158 −1,239

Conversation

@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented Oct 2, 2019 •
edited by SimonSapin

Automated downstream sync of changes from upstream as of 02-10-2019.
[no-wpt-sync]
r? @servo-wpt-sync

This change is Reviewable
@servo-wpt-sync
Update web-platform-tests to revision 64e0fbcb8fc1322148b712026ed5c4d…
Loading status checks…
d980d98 
…afb173544
@servo-wpt-sync
Copy link
Collaborator Author

servo-wpt-sync commented Oct 2, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Oct 2, 2019

📌 Commit d980d98 has been approved by servo-wpt-sync
@bors-servo
Copy link
Contributor

bors-servo commented Oct 3, 2019

⌛ Testing commit d980d98 with merge 4b0fb4e...
bors-servo added a commit that referenced this pull request Oct 3, 2019
@bors-servo
Auto merge of #24346 - servo-wpt-sync:wpt_update_02-10-2019, r=servo-…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
4b0fb4e 
…wpt-sync

Sync WPT with upstream (02-10-2019)

Automated downstream sync of changes from upstream as of 02-10-2019.
[no-wpt-sync]
r? @servo-wpt-sync

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24346)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 3, 2019

💔 Test failed - linux-rel-css
@CYBAI
Copy link
Collaborator

CYBAI commented Oct 3, 2019

I wonder if this is an intermittent failure 🤔 because the test is updated to reference the right file.

{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": null, 
    "test": "/css/css-text/hyphens/hyphens-out-of-flow-001.html", 
    "line": 71139, 
    "action": "test_result", 
    "expected": "FAIL"
}
@jdm
Copy link
Member

jdm commented Oct 3, 2019

@bors-servo retry
@CYBAI
Copy link
Collaborator

CYBAI commented Oct 3, 2019 •
edited

Oops, @jdm Sorry, I didn't say that clearly.

I mean, should we remove the tests/wpt/metadata/css/css-text/hyphens/hyphens-out-of-flow-001.html.ini file? It wasn't removed by @servo-wpt-sync 🤔
@jdm
Copy link
Member

jdm commented Oct 3, 2019

The test failed on macOS when it ran as part of the syncing process, and it passed on linux when we tried to merge it. It's either #23290 or the change to the test introduced a new, different intermittent result.
@CYBAI
Copy link
Collaborator

CYBAI commented Oct 3, 2019

The test failed on macOS when it ran as part of the syncing process, and it passed on linux when we tried to merge it.

I see!! Thanks!! but one more thing I'm confused 👀

💔 Test failed - linux-rel-css

Didn't this one fail on linux? 🤔
@jdm
Copy link
Member

jdm commented Oct 3, 2019 

    "status": "PASS", 
    "expected": "FAIL"
@CYBAI
Copy link
Collaborator

CYBAI commented Oct 3, 2019

Ahhh, I see!!! Thank you 🙏
@bors-servo
Copy link
Contributor

bors-servo commented Oct 3, 2019

⌛ Testing commit d980d98 with merge 3581656...
bors-servo added a commit that referenced this pull request Oct 3, 2019
@bors-servo
Auto merge of #24346 - servo-wpt-sync:wpt_update_02-10-2019, r=servo-…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3581656 
…wpt-sync

Sync WPT with upstream (02-10-2019)

Automated downstream sync of changes from upstream as of 02-10-2019.
[no-wpt-sync]
r? @servo-wpt-sync

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24346)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 3, 2019

💔 Test failed - linux-rel-wpt
@CYBAI
Copy link
Collaborator

CYBAI commented Oct 3, 2019

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Oct 3, 2019

💣 Failed to start rebuilding: Unknown error
@bors-servo
Copy link
Contributor

bors-servo commented Oct 3, 2019

⌛ Testing commit d980d98 with merge 2953d43...
bors-servo added a commit that referenced this pull request Oct 3, 2019
@bors-servo
Auto merge of #24346 - servo-wpt-sync:wpt_update_02-10-2019, r=servo-…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
2953d43 
…wpt-sync

Sync WPT with upstream (02-10-2019)

Automated downstream sync of changes from upstream as of 02-10-2019.
[no-wpt-sync]
r? @servo-wpt-sync

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24346)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 3, 2019

💔 Test failed - status-taskcluster
@jdm jdm closed this Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@servo-wpt-sync servo-wpt-sync

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@servo-wpt-sync @bors-servo @CYBAI @jdm @highfive
You can’t perform that action at this time.