Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSupport input tracking loss and selection events in XR #24362
Merged
+185
−44
Conversation
highfive
commented
Oct 3, 2019
|
Heads up! This PR modifies the following files:
|
highfive
commented
Oct 3, 2019
|
|
Manishearth
force-pushed the
Manishearth:input-selections
branch
from
9a8992b
to
09d978d
Manishearth
force-pushed the
Manishearth:input-selections
branch
from
09d978d
to
d6470c4
Manishearth
changed the title
|
Just a minor question. otherwise LGTM. You can r=me. I'm a bit surprised there's no tests that now pass. |
| .find(|s| s.id() == input) | ||
| .map(|x| DomRoot::from_ref(&**x)); | ||
| if let Some(source) = source { | ||
| let frame = XRFrame::new(&self.global(), self, frame); |
This comment has been minimized.
This comment has been minimized.
asajeffrey
Oct 3, 2019
Member
Do you have a spec link for this? Generating a new frame here seems odd, since we're not in an rAF.
This comment has been minimized.
This comment has been minimized.
Manishearth
Oct 3, 2019
Author
Member
https://immersive-web.github.io/webxr/#primary-action , each event comes with a frame
There's a concept of a non-animation frame "frame", which is basically for updating input poses.
|
Tests won't pass since we've not added headless support for this yet. |
Manishearth
force-pushed the
Manishearth:input-selections
branch
from
d6470c4
to
cf60776
Manishearth
force-pushed the
Manishearth:input-selections
branch
from
cf60776
to
931f0b1
|
@bors-servo r=asajeffrey |
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 4, 2019
Support input tracking loss and selection events in XR Fixes #24192 Requires servo/webxr#65 r? @jdm @asajeffrey <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24362) <!-- Reviewable:end -->
|
|
bors-servo
added a commit
to servo/webxr
that referenced
this pull request
Oct 4, 2019
Input support for OpenXR Requires #65 This treats the right hand as an input source. While I've tested the input code, I haven't yet tested this hooked up to the Servo DOM (servo/servo#24362), so I'd like to hold off on merging this until I get a chance Still, feel free to review the last few commits that have "openxr" in their bodies
bors-servo
added a commit
to servo/webxr
that referenced
this pull request
Oct 4, 2019
Input support for OpenXR Requires #65 This treats the right hand as an input source. While I've tested the input code, I haven't yet tested this hooked up to the Servo DOM (servo/servo#24362), so I'd like to hold off on merging this until I get a chance Still, feel free to review the last few commits that have "openxr" in their bodies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Manishearth commentedOct 3, 2019
•
edited by SimonSapin
Fixes #24192
Requires servo/webxr#65
r? @jdm @asajeffrey
This change is