Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upPass argument by reference to CacheKey constructor #24374
Merged
+5
−5
Conversation
Argument now passed by reference, and clone() removed when calling constructor.
highfive
commented
Oct 5, 2019
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @asajeffrey (or someone else) soon. |
highfive
commented
Oct 5, 2019
|
Heads up! This PR modifies the following files:
|
highfive
commented
Oct 5, 2019
|
|
|
@jdm @asajeffrey @Tugdual, release build also didn't report any error. |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 5, 2019
Pass argument by reference to CacheKey constructor <!-- Please describe your changes on the following line: --> Argument now passed by reference, and clone() removed when calling constructor. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #24353 (GitHub issue number if applicable) <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because @jdm said it only need to build <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24374) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Tugdual commentedOct 5, 2019
•
edited
Argument now passed by reference, and clone() removed when calling
constructor.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is