Dom response check opaque filter #24379

PeaceRebel · 2019-10-05T22:04:17Z

Added setters for url_list, status, and body in Response. Response members are set for Network Error, Opaque and Opaque-redirect responses.

./mach build -d does not report any errors
./mach test-tidy does not report any errors
These changes fix #24372 (GitHub issue number if applicable)

There are tests for these changes

This change is

highfive · 2019-10-05T22:04:25Z

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @SimonSapin (or someone else) soon.

highfive · 2019-10-05T22:04:26Z

Heads up! This PR modifies the following files:

@asajeffrey: components/script/fetch.rs, components/script/dom/response.rs
@KiChjang: components/script/fetch.rs, components/script/dom/response.rs

highfive · 2019-10-05T22:04:28Z

Warning

These commits modify script code, but no tests are modified. Please consider adding a test!

CYBAI · 2019-10-06T14:23:43Z

@bors-servo try=wpt

bors-servo · 2019-10-06T14:23:48Z

⌛ Trying commit cb32e6b with merge ee6ac9e...


        Auto merge of #24379 - PeaceRebel:dom_response_check_opaque_filter, r…

…=<try> Dom response check opaque filter  Added setters for url_list, status, and body in `Response`. Response members are set for [Network Error](https://fetch.spec.whatwg.org/#concept-network-error), [Opaque](https://fetch.spec.whatwg.org/#concept-filtered-response-opaque) and [Opaque-redirect](https://fetch.spec.whatwg.org/#concept-filtered-response-opaque-redirect) responses. ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #24372 (GitHub issue number if applicable)  - [x] There are tests for these changes OR - [X] These changes do not require tests because running tests specified in the #24372 doesn't report any error.    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24379)

bors-servo · 2019-10-06T14:51:14Z

💔 Test failed - linux-rel-css

PeaceRebel · 2019-10-06T15:11:01Z

Can somebody tell me what happened here?

CYBAI · 2019-10-07T01:42:44Z

Can somebody tell me what happened here?

I asked @bors-servo to run CI on linux for this PR and there's an unexpected result.

{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "Empty string integrity for opaque response", 
    "test": "/fetch/api/basic/integrity.sub.any.worker.html", 
    "line": 85762, 
    "action": "test_result", 
    "expected": "FAIL"
}

The Empty string integrity for opaque response test case was failed before this patch. With the fix in this PR, the Empty string integrity for opaque response is passed now.

So, next step, you can remove its test expectation in its metadata file in tests/wpt/metadata/fetch/api/basic/integrity.sub.any.js.ini.

(But, I suspected why the fix only works for the worker one and still failed on the .any.html one 🤔)

Note

You can also read my blog post about wpt and test expectation to understand what happened here.

jdm · 2019-10-07T14:40:34Z

Two other tests that passed:

{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "redirect response with empty Location, manual mode", 
    "test": "/fetch/api/redirect/redirect-empty-location.any.worker.html", 
    "line": 153138, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "redirect response with empty Location, manual mode", 
    "test": "/fetch/api/redirect/redirect-empty-location.any.html", 
    "line": 164448, 
    "action": "test_result", 
    "expected": "FAIL"
}

components/script/fetch.rs

jdm · 2019-10-07T14:57:50Z

Also once #24378 merges I expect more tests to start passing as well.

jdm · 2019-10-08T16:27:47Z

@bors-servo try=wpt

bors-servo · 2019-10-08T16:27:51Z

⌛ Trying commit 8041999 with merge c7b2e27...


        Auto merge of #24379 - PeaceRebel:dom_response_check_opaque_filter, r…

…=<try> Dom response check opaque filter  Added setters for url_list, status, and body in `Response`. Response members are set for [Network Error](https://fetch.spec.whatwg.org/#concept-network-error), [Opaque](https://fetch.spec.whatwg.org/#concept-filtered-response-opaque) and [Opaque-redirect](https://fetch.spec.whatwg.org/#concept-filtered-response-opaque-redirect) responses. ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #24372 (GitHub issue number if applicable)  - [x] There are tests for these changes OR - [X] These changes do not require tests because running tests specified in the #24372 doesn't report any error.    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24379)

jdm · 2019-10-08T17:28:45Z

So many passing tests!

{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "Empty string integrity for opaque response", 
    "test": "/fetch/api/basic/integrity.sub.any.worker.html", 
    "line": 85398, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "Fetch https://web-platform.test:8443/fetch/api/resources/top.txt with no-cors mode", 
    "test": "/fetch/api/basic/mode-no-cors.sub.any.worker.html", 
    "line": 145539, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "Fetch http://web-platform.test:8001/fetch/api/resources/top.txt with no-cors mode", 
    "test": "/fetch/api/basic/mode-no-cors.sub.any.worker.html", 
    "line": 145540, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "Fetch https://web-platform.test:8443/fetch/api/resources/top.txt with no-cors mode", 
    "test": "/fetch/api/basic/mode-no-cors.sub.any.html", 
    "line": 151678, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "Fetch http://web-platform.test:8001/fetch/api/resources/top.txt with no-cors mode", 
    "test": "/fetch/api/basic/mode-no-cors.sub.any.html", 
    "line": 151679, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "redirect response with empty Location, manual mode", 
    "test": "/fetch/api/redirect/redirect-empty-location.any.worker.html", 
    "line": 69904, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "Redirect 301 in \"manual\" mode without location", 
    "test": "/fetch/api/redirect/redirect-location.any.html", 
    "line": 76016, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "Redirect 301 in \"manual\" mode with invalid location", 
    "test": "/fetch/api/redirect/redirect-location.any.html", 
    "line": 76021, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "Redirect 301 in \"manual\" mode with data location", 
    "test": "/fetch/api/redirect/redirect-location.any.html", 
    "line": 76026, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "Redirect 302 in \"manual\" mode without location", 
    "test": "/fetch/api/redirect/redirect-location.any.html", 
    "line": 76031, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "Redirect 302 in \"manual\" mode with invalid location", 
    "test": "/fetch/api/redirect/redirect-location.any.html", 
    "line": 76036, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "Redirect 302 in \"manual\" mode with data location", 
    "test": "/fetch/api/redirect/redirect-location.any.html", 
    "line": 76040, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "Redirect 303 in \"manual\" mode without location", 
    "test": "/fetch/api/redirect/redirect-location.any.html", 
    "line": 76045, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "Redirect 303 in \"manual\" mode with invalid location", 
    "test": "/fetch/api/redirect/redirect-location.any.html", 
    "line": 76049, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "Redirect 303 in \"manual\" mode with data location", 
    "test": "/fetch/api/redirect/redirect-location.any.html", 
    "line": 76051, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "Redirect 307 in \"manual\" mode without location", 
    "test": "/fetch/api/redirect/redirect-location.any.html", 
    "line": 76053, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "Redirect 307 in \"manual\" mode with invalid location", 
    "test": "/fetch/api/redirect/redirect-location.any.html", 
    "line": 76055, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "Redirect 307 in \"manual\" mode with data location", 
    "test": "/fetch/api/redirect/redirect-location.any.html", 
    "line": 76057, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "Redirect 308 in \"manual\" mode without location", 
    "test": "/fetch/api/redirect/redirect-location.any.html", 
    "line": 76059, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "Redirect 308 in \"manual\" mode with invalid location", 
    "test": "/fetch/api/redirect/redirect-location.any.html", 
    "line": 76061, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "Redirect 308 in \"manual\" mode with data location", 
    "test": "/fetch/api/redirect/redirect-location.any.html", 
    "line": 76063, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "redirect response with empty Location, manual mode", 
    "test": "/fetch/api/redirect/redirect-empty-location.any.html", 
    "line": 78822, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "Same domain different port [no-cors mode]", 
    "test": "/fetch/api/cors/cors-basic.any.worker.html", 
    "line": 101818, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "Same domain different protocol different port [no-cors mode]", 
    "test": "/fetch/api/cors/cors-basic.any.worker.html", 
    "line": 101821, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "Cross domain basic usage [no-cors mode]", 
    "test": "/fetch/api/cors/cors-basic.any.worker.html", 
    "line": 101824, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "Cross domain different port [no-cors mode]", 
    "test": "/fetch/api/cors/cors-basic.any.worker.html", 
    "line": 101827, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "Cross domain different protocol [no-cors mode]", 
    "test": "/fetch/api/cors/cors-basic.any.worker.html", 
    "line": 101830, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "Same domain different port [no-cors mode]", 
    "test": "/fetch/api/cors/cors-basic.any.html", 
    "line": 175043, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "Same domain different protocol different port [no-cors mode]", 
    "test": "/fetch/api/cors/cors-basic.any.html", 
    "line": 175046, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "Cross domain basic usage [no-cors mode]", 
    "test": "/fetch/api/cors/cors-basic.any.html", 
    "line": 175049, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "Cross domain different port [no-cors mode]", 
    "test": "/fetch/api/cors/cors-basic.any.html", 
    "line": 175052, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "Cross domain different protocol [no-cors mode]", 
    "test": "/fetch/api/cors/cors-basic.any.html", 
    "line": 175055, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "Redirect 301 in \"manual\" mode without location", 
    "test": "/fetch/api/redirect/redirect-location.any.worker.html", 
    "line": 208488, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "Redirect 301 in \"manual\" mode with invalid location", 
    "test": "/fetch/api/redirect/redirect-location.any.worker.html", 
    "line": 208490, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "Redirect 301 in \"manual\" mode with data location", 
    "test": "/fetch/api/redirect/redirect-location.any.worker.html", 
    "line": 208492, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "Redirect 302 in \"manual\" mode without location", 
    "test": "/fetch/api/redirect/redirect-location.any.worker.html", 
    "line": 208494, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "Redirect 302 in \"manual\" mode with invalid location", 
    "test": "/fetch/api/redirect/redirect-location.any.worker.html", 
    "line": 208496, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "Redirect 302 in \"manual\" mode with data location", 
    "test": "/fetch/api/redirect/redirect-location.any.worker.html", 
    "line": 208498, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "Redirect 303 in \"manual\" mode without location", 
    "test": "/fetch/api/redirect/redirect-location.any.worker.html", 
    "line": 208500, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "Redirect 303 in \"manual\" mode with invalid location", 
    "test": "/fetch/api/redirect/redirect-location.any.worker.html", 
    "line": 208502, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "Redirect 303 in \"manual\" mode with data location", 
    "test": "/fetch/api/redirect/redirect-location.any.worker.html", 
    "line": 208504, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "Redirect 307 in \"manual\" mode without location", 
    "test": "/fetch/api/redirect/redirect-location.any.worker.html", 
    "line": 208506, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "Redirect 307 in \"manual\" mode with invalid location", 
    "test": "/fetch/api/redirect/redirect-location.any.worker.html", 
    "line": 208508, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "Redirect 307 in \"manual\" mode with data location", 
    "test": "/fetch/api/redirect/redirect-location.any.worker.html", 
    "line": 208510, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "Redirect 308 in \"manual\" mode without location", 
    "test": "/fetch/api/redirect/redirect-location.any.worker.html", 
    "line": 208512, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "Redirect 308 in \"manual\" mode with invalid location", 
    "test": "/fetch/api/redirect/redirect-location.any.worker.html", 
    "line": 208514, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "Redirect 308 in \"manual\" mode with data location", 
    "test": "/fetch/api/redirect/redirect-location.any.worker.html", 
    "line": 208516, 
    "action": "test_result", 
    "expected": "FAIL"
}

PeaceRebel · 2019-10-08T17:34:13Z

@jdm, in this case, does that mean something bad?

jdm · 2019-10-08T18:09:52Z

It means good things. But it does mean that you need to update the expected results to reflect the fact that they tests now pass.

bors-servo · 2019-10-11T12:24:49Z

📌 Commit 0f1ddc6 has been approved by jdm

bors-servo · 2019-10-11T12:24:55Z

⌛ Testing commit 0f1ddc6 with merge 30ecaa0...


        Auto merge of #24379 - PeaceRebel:dom_response_check_opaque_filter, r…

…=jdm Dom response check opaque filter  Added setters for url_list, status, and body in `Response`. Response members are set for [Network Error](https://fetch.spec.whatwg.org/#concept-network-error), [Opaque](https://fetch.spec.whatwg.org/#concept-filtered-response-opaque) and [Opaque-redirect](https://fetch.spec.whatwg.org/#concept-filtered-response-opaque-redirect) responses. ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #24372 (GitHub issue number if applicable)  - [x] There are tests for these changes    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24379)

bors-servo · 2019-10-11T13:01:02Z

💔 Test failed - linux-rel-wpt

CYBAI · 2019-10-11T13:28:51Z

@bors-servo retry

#24161

bors-servo · 2019-10-11T13:28:55Z

⌛ Testing commit 0f1ddc6 with merge da14221...


        Auto merge of #24379 - PeaceRebel:dom_response_check_opaque_filter, r…

…=jdm Dom response check opaque filter  Added setters for url_list, status, and body in `Response`. Response members are set for [Network Error](https://fetch.spec.whatwg.org/#concept-network-error), [Opaque](https://fetch.spec.whatwg.org/#concept-filtered-response-opaque) and [Opaque-redirect](https://fetch.spec.whatwg.org/#concept-filtered-response-opaque-redirect) responses. ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #24372 (GitHub issue number if applicable)  - [x] There are tests for these changes    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24379)

bors-servo · 2019-10-11T14:36:04Z

💔 Test failed - status-taskcluster

jdm · 2019-10-11T14:45:52Z

@bors-servo retry

#23290

bors-servo · 2019-10-11T14:45:55Z

💣 Failed to start rebuilding: Unknown error

bors-servo · 2019-10-11T14:46:00Z

⌛ Testing commit 0f1ddc6 with merge 723df4a...


        Auto merge of #24379 - PeaceRebel:dom_response_check_opaque_filter, r…

…=jdm Dom response check opaque filter  Added setters for url_list, status, and body in `Response`. Response members are set for [Network Error](https://fetch.spec.whatwg.org/#concept-network-error), [Opaque](https://fetch.spec.whatwg.org/#concept-filtered-response-opaque) and [Opaque-redirect](https://fetch.spec.whatwg.org/#concept-filtered-response-opaque-redirect) responses. ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #24372 (GitHub issue number if applicable)  - [x] There are tests for these changes    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24379)

bors-servo · 2019-10-11T15:27:51Z

💔 Test failed - linux-rel-wpt

jdm · 2019-10-11T15:41:14Z

@bors-servo retry

#24423

bors-servo · 2019-10-11T16:08:53Z

⚡ Previous build results for linux-rel-css, status-taskcluster are reusable. Rebuilding only linux-rel-wpt...

bors-servo · 2019-10-11T16:49:13Z

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: jdm
Pushing 723df4a to master...

highfive assigned SimonSapin Oct 5, 2019

highfive added the S-awaiting-review label Oct 5, 2019

highfive added the S-tests-failed label Oct 6, 2019

jdm mentioned this pull request Oct 7, 2019

response: remove text from default statusCode #24378

Merged

4 of 4 tasks complete

jdm requested changes Oct 7, 2019

View changes

components/script/fetch.rs Outdated Show resolved Hide resolved

jdm added S-needs-code-changes and removed S-awaiting-review labels Oct 7, 2019

highfive added S-awaiting-review and removed S-tests-failed S-needs-code-changes labels Oct 8, 2019

PeaceRebel requested a review from jdm Oct 8, 2019

jdm assigned jdm and unassigned SimonSapin Oct 8, 2019

highfive added S-awaiting-merge and removed S-awaiting-review labels Oct 11, 2019

highfive added S-tests-failed and removed S-awaiting-merge labels Oct 11, 2019

highfive added S-awaiting-merge and removed S-tests-failed labels Oct 11, 2019

highfive added S-tests-failed and removed S-awaiting-merge labels Oct 11, 2019

highfive added S-awaiting-merge and removed S-tests-failed labels Oct 11, 2019

highfive added S-tests-failed and removed S-awaiting-merge labels Oct 11, 2019

bors-servo merged commit 0f1ddc6 into servo:master Oct 11, 2019
3 checks passed

3 checks passed

Taskcluster (pull_request) TaskGroup: success
Details

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

homu Test successful
Details

PeaceRebel deleted the PeaceRebel:dom_response_check_opaque_filter branch Oct 11, 2019

servo / servo

Dom response check opaque filter #24379

Dom response check opaque filter #24379

PeaceRebel commented Oct 5, 2019 •

edited by jdm

highfive commented Oct 5, 2019

highfive commented Oct 5, 2019

highfive commented Oct 5, 2019

CYBAI commented Oct 6, 2019

bors-servo commented Oct 6, 2019

bors-servo commented Oct 6, 2019

PeaceRebel commented Oct 6, 2019

CYBAI commented Oct 7, 2019 •

edited

jdm commented Oct 7, 2019

jdm commented Oct 7, 2019

jdm commented Oct 8, 2019

bors-servo commented Oct 8, 2019

jdm commented Oct 8, 2019

PeaceRebel commented Oct 8, 2019

jdm commented Oct 8, 2019

bors-servo commented Oct 11, 2019

bors-servo commented Oct 11, 2019

bors-servo commented Oct 11, 2019

CYBAI commented Oct 11, 2019

bors-servo commented Oct 11, 2019

bors-servo commented Oct 11, 2019

jdm commented Oct 11, 2019

bors-servo commented Oct 11, 2019

bors-servo commented Oct 11, 2019

bors-servo commented Oct 11, 2019

jdm commented Oct 11, 2019

bors-servo commented Oct 11, 2019

bors-servo commented Oct 11, 2019

servo / servo

Join GitHub today

Dom response check opaque filter #24379

Dom response check opaque filter #24379

Conversation

PeaceRebel commented Oct 5, 2019 • edited by jdm

highfive commented Oct 5, 2019

highfive commented Oct 5, 2019

highfive commented Oct 5, 2019

CYBAI commented Oct 6, 2019

bors-servo commented Oct 6, 2019

bors-servo commented Oct 6, 2019

PeaceRebel commented Oct 6, 2019

CYBAI commented Oct 7, 2019 • edited

Note

jdm commented Oct 7, 2019

jdm commented Oct 7, 2019

jdm commented Oct 8, 2019

bors-servo commented Oct 8, 2019

jdm commented Oct 8, 2019

PeaceRebel commented Oct 8, 2019

jdm commented Oct 8, 2019

bors-servo commented Oct 11, 2019

bors-servo commented Oct 11, 2019

bors-servo commented Oct 11, 2019

CYBAI commented Oct 11, 2019

bors-servo commented Oct 11, 2019

bors-servo commented Oct 11, 2019

jdm commented Oct 11, 2019

bors-servo commented Oct 11, 2019

bors-servo commented Oct 11, 2019

bors-servo commented Oct 11, 2019

jdm commented Oct 11, 2019

bors-servo commented Oct 11, 2019

bors-servo commented Oct 11, 2019

PeaceRebel commented Oct 5, 2019 •

edited by jdm

CYBAI commented Oct 7, 2019 •

edited