Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new way of doing input source arrays #24397

Merged
merged 5 commits into from Oct 9, 2019
Merged

Support new way of doing input source arrays #24397

merged 5 commits into from Oct 9, 2019
+110 −61

Conversation

@Manishearth
Copy link
Member

Manishearth commented Oct 8, 2019 •
edited by SimonSapin

Fixes #24395

r? @jdm

This change is Reviewable
Manishearth added 4 commits Oct 8, 2019
@Manishearth
Add empty XRInputSourceArray interface
b5b852b
@Manishearth
Store inputs array in XRInputSourceArray
0777233
@Manishearth
Add methods to XRInputSourceArray
868e5cb
@Manishearth
Hook XRInputSourceArray into XRSession
Loading status checks…
8ae1c2e
@highfive
Copy link

highfive commented Oct 8, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/mod.rs, components/script/dom/webidls/XRSession.webidl, components/script/dom/xrsession.rs, components/script/dom/xrinputsourcearray.rs, components/script/dom/webidls/XRInputSourceArray.webidl
  • @KiChjang: components/script/dom/mod.rs, components/script/dom/webidls/XRSession.webidl, components/script/dom/xrsession.rs, components/script/dom/xrinputsourcearray.rs, components/script/dom/webidls/XRInputSourceArray.webidl
@highfive
Copy link

highfive commented Oct 8, 2019

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@jdm
Copy link
Member

jdm commented Oct 8, 2019

@bors-servo try=wpt
@bors-servo
Copy link
Contributor

bors-servo commented Oct 8, 2019

⌛ Trying commit 8ae1c2e with merge 91032d6...
bors-servo added a commit that referenced this pull request Oct 8, 2019
@bors-servo
Auto merge of #24397 - Manishearth:inputarray, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
91032d6 
Support new way of doing input source arrays

Fixes #24395

r? @jdm

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24397)
<!-- Reviewable:end -->
@jdm
jdm approved these changes Oct 8, 2019
View changes
@Manishearth
Copy link
Member Author

Manishearth commented Oct 8, 2019

I was doing a local run, pushed expectations

@bors-servo r=jdm
@bors-servo
Copy link
Contributor

bors-servo commented Oct 8, 2019

📌 Commit cb134ee has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Oct 8, 2019

⌛ Testing commit cb134ee with merge a753f12...
bors-servo added a commit that referenced this pull request Oct 8, 2019
@bors-servo
Auto merge of #24397 - Manishearth:inputarray, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a753f12 
Support new way of doing input source arrays

Fixes #24395

r? @jdm

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24397)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 8, 2019

💔 Test failed - linux-rel-css
@Manishearth
Copy link
Member Author

Manishearth commented Oct 8, 2019

@bors-servo retry

{
    "status": "CRASH", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": null, 
    "test": "/fetch/stale-while-revalidate/fetch.html", 
    "line": 162486, 
    "action": "test_result", 
    "expected": "OK"
}
@bors-servo
Copy link
Contributor

bors-servo commented Oct 8, 2019

⌛ Testing commit cb134ee with merge f19c1fb...
bors-servo added a commit that referenced this pull request Oct 8, 2019
@bors-servo
Auto merge of #24397 - Manishearth:inputarray, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f19c1fb 
Support new way of doing input source arrays

Fixes #24395

r? @jdm

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24397)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 9, 2019

💔 Test failed - linux-rel-wpt
@Manishearth
Update WPT
Loading status checks…
c812fe0
@Manishearth Manishearth force-pushed the Manishearth:inputarray branch from cb134ee to c812fe0 Oct 9, 2019
@Manishearth
Copy link
Member Author

Manishearth commented Oct 9, 2019

@bors-servo r=jdm

(iirc that's one of the tests that's flakier in debug)
@bors-servo
Copy link
Contributor

bors-servo commented Oct 9, 2019

📌 Commit c812fe0 has been approved by jdm
bors-servo added a commit that referenced this pull request Oct 9, 2019
@bors-servo
Auto merge of #24397 - Manishearth:inputarray, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ec408e9 
Support new way of doing input source arrays

Fixes #24395

r? @jdm

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24397)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 9, 2019

⌛ Testing commit c812fe0 with merge ec408e9...
@jdm
Copy link
Member

jdm commented Oct 9, 2019

Filed #24399 because it was a panic I had never observed before.
@Manishearth
Copy link
Member Author

Manishearth commented Oct 9, 2019

Yep, was holding off on filing till this landed
@Manishearth
Copy link
Member Author

Manishearth commented Oct 9, 2019

Oh, also, I was able to get the ballshooter example working with this (and servo/webxr#67 ) , but it stopped working later and I'm not sure why. Hitting the same BindTexture crash, but there's novisible error causing it. Need to investigate further.
@jdm
Copy link
Member

jdm commented Oct 9, 2019

I have a patch that makes the BindTexture crash go away by adding context.Finish() before returning from XRWebGLLayer::Constructor.
@Manishearth
Copy link
Member Author

Manishearth commented Oct 9, 2019

Sweet, I'll see what happens with that patch tomorrow.
@bors-servo
Copy link
Contributor

bors-servo commented Oct 9, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: jdm
Pushing ec408e9 to master...
@bors-servo bors-servo merged commit c812fe0 into servo:master Oct 9, 2019
3 checks passed
3 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@Manishearth Manishearth deleted the Manishearth:inputarray branch Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdm jdm

Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

getInputSources API isn't spec-compliant
4 participants
@Manishearth @highfive @jdm @bors-servo
You can’t perform that action at this time.