Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFetch: ensure consistency between response, done-chan, and cache state. #24401
Conversation
gterzian
force-pushed the
gterzian:ensure_done_chan_is_none_when_revalidating
branch
from
81d31f0
to
830410f
gterzian
changed the title
gterzian
force-pushed the
gterzian:ensure_done_chan_is_none_when_revalidating
branch
from
830410f
to
be42a62
gterzian
changed the title
|
The issue also affected the cache state, since concurrent fetches should also wait for a pending revalidation. |
gterzian
force-pushed the
gterzian:ensure_done_chan_is_none_when_revalidating
branch
from
be42a62
to
bb1fa88
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 9, 2019
…ating, r=jdm Fetch: ensure consistency between response, done-chan, and cache state. This ensures that when a cached response is not used because it requires revalidation, the done chan is set back to `None`(since the cache might have set it to `Some` when constructing the response requiring revalidation). <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #24399 (GitHub issue number if applicable) <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24401) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
gterzian commentedOct 9, 2019
•
edited
This ensures that when a cached response is not used because it requires revalidation, the done chan is set back to
None(since the cache might have set it toSomewhen constructing the response requiring revalidation)../mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is