Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements pageX and pageY attributes on MouseEvent interface #24409

Merged
merged 1 commit into from Oct 17, 2019
Merged

Implements pageX and pageY attributes on MouseEvent interface #24409

merged 1 commit into from Oct 17, 2019

Conversation

@tigleym
Copy link
Contributor

tigleym commented Oct 9, 2019 •
edited by jdm

Implements missing pageX and pageY on MouseEvent interface.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #24248 (GitHub issue number if applicable)
  • There are tests for these changes OR
  • These changes do not require tests because ___

This change is Reviewable
@highfive
Copy link

highfive commented Oct 9, 2019

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @asajeffrey (or someone else) soon.
@highfive
Copy link

highfive commented Oct 9, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/webidls/MouseEvent.webidl, components/script/dom/mouseevent.rs
  • @KiChjang: components/script/dom/webidls/MouseEvent.webidl, components/script/dom/mouseevent.rs
@servo-wpt-sync servo-wpt-sync mentioned this pull request Oct 9, 2019
Merged
@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented Oct 9, 2019

Opened new PR for upstreamable changes.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#19602.
@jdm jdm assigned jdm and unassigned asajeffrey Oct 10, 2019
@jdm
jdm requested changes Oct 10, 2019
View changes
Copy link
Member

jdm left a comment

Thanks for adding a test!
tests/wpt/web-platform-tests/css/cssom-view/mouseEvent.html Show resolved Hide resolved
components/script/dom/mouseevent.rs Outdated Show resolved Hide resolved
@tigleym tigleym force-pushed the tigleym:mouse_event_cssom_attributes branch from d985cb5 to b85524c Oct 16, 2019
@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented Oct 16, 2019

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#19602.
@jdm
Copy link
Member

jdm commented Oct 17, 2019

@bors-servo r+
Thanks for digging into this!
@bors-servo
Copy link
Contributor

bors-servo commented Oct 17, 2019

📌 Commit b85524c has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Oct 17, 2019

⌛ Testing commit b85524c with merge 68f16c7...
bors-servo added a commit that referenced this pull request Oct 17, 2019
@bors-servo
Auto merge of #24409 - tigleym:mouse_event_cssom_attributes, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
68f16c7 
Implements pageX and pageY attributes on MouseEvent interface

<!-- Please describe your changes on the following line: -->
Implements missing pageX and pageY on MouseEvent interface.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [x] These changes fix #24248 (GitHub issue number if applicable)

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24409)
<!-- Reviewable:end -->
@tigleym tigleym mentioned this pull request Oct 17, 2019
Open
@bors-servo
Copy link
Contributor

bors-servo commented Oct 17, 2019

💔 Test failed - linux-rel-wpt
@jdm
Copy link
Member

jdm commented Oct 17, 2019 

{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "MouseEvent interface: new MouseEvent(\"foo\") must inherit property \"pageX\" with the proper type", 
    "test": "/css/cssom-view/idlharness.html", 
    "line": 148591, 
    "action": "test_result", 
    "expected": "FAIL"
}
{
    "status": "PASS", 
    "group": "default", 
    "message": null, 
    "stack": null, 
    "subtest": "MouseEvent interface: new MouseEvent(\"foo\") must inherit property \"pageY\" with the proper type", 
    "test": "/css/cssom-view/idlharness.html", 
    "line": 148592, 
    "action": "test_result", 
    "expected": "FAIL"
}

Woo!
@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented Oct 17, 2019

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#19602.
@jdm
Copy link
Member

jdm commented Oct 17, 2019

Go ahead and squash the commits together.
@tigleym
Implements pageX and pageY attributes
Loading status checks…
4b93a23
@tigleym tigleym force-pushed the tigleym:mouse_event_cssom_attributes branch from 824768c to 4b93a23 Oct 17, 2019
@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented Oct 17, 2019

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#19602.
@jdm
Copy link
Member

jdm commented Oct 17, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Oct 17, 2019

📌 Commit 4b93a23 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Oct 17, 2019

⌛ Testing commit 4b93a23 with merge 0162067...
bors-servo added a commit that referenced this pull request Oct 17, 2019
@bors-servo
Auto merge of #24409 - tigleym:mouse_event_cssom_attributes, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0162067 
Implements pageX and pageY attributes on MouseEvent interface

<!-- Please describe your changes on the following line: -->
Implements missing pageX and pageY on MouseEvent interface.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [x] These changes fix #24248 (GitHub issue number if applicable)

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24409)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 17, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: jdm
Pushing 0162067 to master...
@bors-servo bors-servo merged commit 4b93a23 into servo:master Oct 17, 2019
2 checks passed
2 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
homu Test successful
Details
@jdm jdm mentioned this pull request Oct 18, 2019
Closed
@tigleym tigleym deleted the tigleym:mouse_event_cssom_attributes branch Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdm jdm

Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Missing MouseEvent attributes defined by CSSOM View
6 participants
@tigleym @highfive @servo-wpt-sync @jdm @bors-servo @asajeffrey
You can’t perform that action at this time.