Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up[WIP] Enable WPT on Linux in Taskcluster #24418
Closed
Conversation
|
It's been almost a year since we last tried this, so let's see if anything has changed. |
bors-servo
added a commit
that referenced
this pull request
Oct 10, 2019
[WIP] Enable WPT on Linux in Taskcluster <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24418) <!-- Reviewable:end -->
|
|
|
Awkward:
|
|
@bors-servo try=arm |
bors-servo
added a commit
that referenced
this pull request
Oct 10, 2019
[WIP] Enable WPT on Linux in Taskcluster <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24418) <!-- Reviewable:end -->
|
|
|
Same error. |
| @@ -762,7 +765,7 @@ def linux_build_task(name, *, build_env=build_env): | |||
| .with_index_and_artifacts_expire_in(build_artifacts_expire_in) | |||
| .with_max_run_time_minutes(60) | |||
| .with_dockerfile(dockerfile_path("build")) | |||
| .with_env(**build_env, **unix_build_env, **linux_build_env) | |||
| .with_env(**build_env, **unix_build_env, **linux_env, **linux_build_env) | |||
This comment has been minimized.
This comment has been minimized.
SimonSapin
Oct 11, 2019
Member
Since this function calls linux_task() there is no need to repeat linux_env here.
Maybe Python (distutils?) doesn’t try to use Clang when it doesn’t find GCC? |
|
|
bors-servo
added a commit
that referenced
this pull request
Nov 19, 2019
bors-servo
added a commit
that referenced
this pull request
Nov 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jdm commentedOct 10, 2019
•
edited by SimonSapin
This change is