Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle inline-block as block for now in layout 2020 #24420

Merged
merged 1 commit into from Oct 11, 2019
Merged

Conversation

@nox
Copy link
Member

nox commented Oct 11, 2019

This change is Reviewable

That makes Servo not panic when loading servo.org.
@SimonSapin
Copy link
Member

SimonSapin commented Oct 11, 2019

@bors-servo
Copy link
Contributor

bors-servo commented Oct 11, 2019

📌 Commit 6345e35 has been approved by SimonSapin

@bors-servo
Copy link
Contributor

bors-servo commented Oct 11, 2019

Testing commit 6345e35 with merge 1e147f8...

bors-servo added a commit that referenced this pull request Oct 11, 2019
Handle inline-block as block for now in layout 2020

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24420)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 11, 2019

💔 Test failed - linux-rel-wpt

@CYBAI
Copy link
Collaborator

CYBAI commented Oct 11, 2019

@bors-servo
Copy link
Contributor

bors-servo commented Oct 11, 2019

Testing commit 6345e35 with merge 9c3a26c...

bors-servo added a commit that referenced this pull request Oct 11, 2019
Handle inline-block as block for now in layout 2020

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24420)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 11, 2019

💔 Test failed - status-taskcluster

@jdm
Copy link
Member

jdm commented Oct 11, 2019

@bors-servo retry

@bors-servo
Copy link
Contributor

bors-servo commented Oct 11, 2019

💣 Failed to start rebuilding: Unknown error

@bors-servo
Copy link
Contributor

bors-servo commented Oct 11, 2019

Testing commit 6345e35 with merge 641f5e6...

bors-servo added a commit that referenced this pull request Oct 11, 2019
Handle inline-block as block for now in layout 2020

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24420)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 11, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: SimonSapin
Pushing 641f5e6 to master...

@bors-servo bors-servo merged commit 6345e35 into master Oct 11, 2019
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
Taskcluster (pull_request) TaskGroup: success
Details
homu Test successful
Details
@bors-servo bors-servo deleted the inline-block-lies branch Oct 11, 2019
@SimonSapin SimonSapin added this to Done / resolved in Layout 2020 Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Layout 2020
  
Merged / resolved
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
You can’t perform that action at this time.