Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use raqote for 2D canvas rendering #24422

Merged
merged 4 commits into from Oct 16, 2019
Merged

Use raqote for 2D canvas rendering #24422

merged 4 commits into from Oct 16, 2019
+16 −13

Conversation

@pylbrecht
Copy link
Contributor

pylbrecht commented Oct 11, 2019 •
edited by SimonSapin

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #23431

This change is Reviewable
@pylbrecht
Copy link
Contributor Author

pylbrecht commented Oct 11, 2019

I'm not quite sure if my implementations are correct, so @jrmuizel, maybe you want to take a look at this, as well.

@jdm, I need some general guidance on how to continue after my changes here have been approved. You mentioned some tests that will show what needs to be implemented?
@pylbrecht
Copy link
Contributor Author

pylbrecht commented Oct 11, 2019

I broke Cargo.lock.. I'm working on it.
@jdm
Copy link
Member

jdm commented Oct 11, 2019

Changing this code to check for the presence of canvas2d-azure and default to canvas2d-raqote if it's not present will swap the default canvas backend, and then running ./mach test-wpt tests/wpt/web-platform-tests/2dcontext will show the difference in test results based on the raqote backend.
@jrmuizel
Copy link

jrmuizel commented Oct 11, 2019

Looks fine to me.
pylbrecht added 4 commits Oct 11, 2019
@pylbrecht
Show warn! for shadow drawing operations
f88c6ef
@pylbrecht
Implement Path::transformed_copy_to_builder()
772f2bc
@pylbrecht
Implement DrawTarget::snapshot()
fa2de68
@pylbrecht
Update raqote
Loading status checks…
9762dd3
@pylbrecht pylbrecht force-pushed the pylbrecht:raqote branch from 920c42d to 9762dd3 Oct 11, 2019
@jdm
Copy link
Member

jdm commented Oct 16, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Oct 16, 2019

📌 Commit 9762dd3 has been approved by jdm
@highfive highfive assigned jdm and unassigned ferjm Oct 16, 2019
@bors-servo
Copy link
Contributor

bors-servo commented Oct 16, 2019

⌛ Testing commit 9762dd3 with merge bcd8c5e...
bors-servo added a commit that referenced this pull request Oct 16, 2019
@bors-servo
Auto merge of #24422 - pylbrecht:raqote, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
bcd8c5e 
 Use raqote for 2D canvas rendering

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #23431

<!-- Either: -->

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24422)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 16, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: jdm
Pushing bcd8c5e to master...
@bors-servo bors-servo merged commit 9762dd3 into servo:master Oct 16, 2019
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
Taskcluster (pull_request) TaskGroup: success
Details
homu Test successful
Details
@pylbrecht pylbrecht mentioned this pull request Oct 17, 2019
Merged
3 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Use raqote for 2D canvas rendering
6 participants
@pylbrecht @jdm @jrmuizel @bors-servo @ferjm @highfive
You can’t perform that action at this time.