Skip to content

Comments

Use raqote for 2D canvas rendering #24422

Merged
bors-servo merged 4 commits intoservo:masterfrom
pylbrecht:raqote
Oct 16, 2019
Merged

Use raqote for 2D canvas rendering #24422
bors-servo merged 4 commits intoservo:masterfrom
pylbrecht:raqote

Conversation

@pylbrecht
Copy link
Contributor

@pylbrecht pylbrecht commented Oct 11, 2019



This change is Reviewable

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Oct 11, 2019
@pylbrecht
Copy link
Contributor Author

I'm not quite sure if my implementations are correct, so @jrmuizel, maybe you want to take a look at this, as well.

@jdm, I need some general guidance on how to continue after my changes here have been approved. You mentioned some tests that will show what needs to be implemented?

@pylbrecht
Copy link
Contributor Author

I broke Cargo.lock.. I'm working on it.

@jdm
Copy link
Member

jdm commented Oct 11, 2019

Changing this code to check for the presence of canvas2d-azure and default to canvas2d-raqote if it's not present will swap the default canvas backend, and then running ./mach test-wpt tests/wpt/web-platform-tests/2dcontext will show the difference in test results based on the raqote backend.

@jrmuizel
Copy link

Looks fine to me.

@jdm
Copy link
Member

jdm commented Oct 16, 2019

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 9762dd3 has been approved by jdm

@highfive highfive assigned jdm and unassigned ferjm Oct 16, 2019
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Oct 16, 2019
@bors-servo
Copy link
Contributor

⌛ Testing commit 9762dd3 with merge bcd8c5e...

bors-servo pushed a commit that referenced this pull request Oct 16, 2019
 Use raqote for 2D canvas rendering

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #23431

<!-- Either: -->

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24422)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: jdm
Pushing bcd8c5e to master...

@bors-servo bors-servo merged commit 9762dd3 into servo:master Oct 16, 2019
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use raqote for 2D canvas rendering

6 participants