Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upVarious XR fixes #24427
Various XR fixes #24427
Conversation
highfive
commented
Oct 11, 2019
|
Heads up! This PR modifies the following files:
|
|
@bors-servo r+ |
|
|
Various XR fixes Mostly making sure we expose the correct things on the XRSession interface. No backend currently supports visibility state changes, and it's tricky to do this for Hololens because currently we must pump the event loop to notice these events, and only rAF pumps the event loop right now, which means that applications which choose to stop running rAF when blurred will have a problem. r? @jdm
|
|
|
@bors-servo retry |
|
|
Various XR fixes Mostly making sure we expose the correct things on the XRSession interface. No backend currently supports visibility state changes, and it's tricky to do this for Hololens because currently we must pump the event loop to notice these events, and only rAF pumps the event loop right now, which means that applications which choose to stop running rAF when blurred will have a problem. r? @jdm
|
|
|
@bors-servo retry |
|
|
|
|
|
Hmm, that's weird. After this PR merged, I pull the latest master. I got following build error:
Then, I opened After checkout the hash id to the latest one, I can build Servo successfully |
Manishearth commentedOct 11, 2019
Mostly making sure we expose the correct things on the XRSession interface.
No backend currently supports visibility state changes, and it's tricky to do this for Hololens because currently we must pump the event loop to notice these events, and only rAF pumps the event loop right now, which means that applications which choose to stop running rAF when blurred will have a problem.
r? @jdm