Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various XR fixes #24427

Merged
merged 5 commits into from Oct 12, 2019
Merged

Various XR fixes #24427

merged 5 commits into from Oct 12, 2019

Conversation

@Manishearth
Copy link
Member

Manishearth commented Oct 11, 2019

Mostly making sure we expose the correct things on the XRSession interface.

No backend currently supports visibility state changes, and it's tricky to do this for Hololens because currently we must pump the event loop to notice these events, and only rAF pumps the event loop right now, which means that applications which choose to stop running rAF when blurred will have a problem.

r? @jdm

@highfive
Copy link

highfive commented Oct 11, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/webidls/XRSession.webidl, components/script/dom/xrsession.rs
  • @KiChjang: components/script/dom/webidls/XRSession.webidl, components/script/dom/xrsession.rs
@Manishearth Manishearth force-pushed the Manishearth:various-xr branch from 1849ff2 to 49a8ed0 Oct 11, 2019
@jdm
Copy link
Member

jdm commented Oct 11, 2019

@bors-servo
Copy link
Contributor

bors-servo commented Oct 11, 2019

📌 Commit 49a8ed0 has been approved by jdm

@bors-servo
Copy link
Contributor

bors-servo commented Oct 11, 2019

Testing commit 49a8ed0 with merge 9a8815e...

bors-servo added a commit that referenced this pull request Oct 11, 2019
Various XR fixes

Mostly making sure we expose the correct things on the XRSession interface.

No backend currently supports visibility state changes, and it's tricky to do this for Hololens because currently we must pump the event loop to notice these events, and only rAF pumps the event loop right now, which means that applications which choose to stop running rAF when blurred will have a problem.

r? @jdm
@bors-servo
Copy link
Contributor

bors-servo commented Oct 12, 2019

💔 Test failed - status-taskcluster

@jdm
Copy link
Member

jdm commented Oct 12, 2019

@bors-servo retry

@bors-servo
Copy link
Contributor

bors-servo commented Oct 12, 2019

💣 Failed to start rebuilding: Unknown error

bors-servo added a commit that referenced this pull request Oct 12, 2019
Various XR fixes

Mostly making sure we expose the correct things on the XRSession interface.

No backend currently supports visibility state changes, and it's tricky to do this for Hololens because currently we must pump the event loop to notice these events, and only rAF pumps the event loop right now, which means that applications which choose to stop running rAF when blurred will have a problem.

r? @jdm
@bors-servo
Copy link
Contributor

bors-servo commented Oct 12, 2019

Testing commit 49a8ed0 with merge a84d4ab...

@bors-servo
Copy link
Contributor

bors-servo commented Oct 12, 2019

💔 Test failed - linux-rel-css

@CYBAI
Copy link
Collaborator

CYBAI commented Oct 12, 2019

@bors-servo
Copy link
Contributor

bors-servo commented Oct 12, 2019

Previous build results for status-taskcluster are reusable. Rebuilding only linux-rel-css, linux-rel-wpt...

@bors-servo
Copy link
Contributor

bors-servo commented Oct 12, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: jdm
Pushing a84d4ab to master...

@bors-servo bors-servo merged commit 49a8ed0 into servo:master Oct 12, 2019
3 checks passed
3 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@CYBAI
Copy link
Collaborator

CYBAI commented Oct 12, 2019

Hmm, that's weird. After this PR merged, I pull the latest master.

I got following build error:

   Compiling script_layout_interface v0.0.1 (/Users/cybai/codespace/mozilla/servo/components/script_layout_interface)
   Compiling layout_traits v0.0.1 (/Users/cybai/codespace/mozilla/servo/components/layout_traits)
   Compiling layout_2013 v0.0.1 (/Users/cybai/codespace/mozilla/servo/components/layout)
   Compiling constellation v0.0.1 (/Users/cybai/codespace/mozilla/servo/components/constellation)
    Building [=====================================================> ] 601/611: mozjs_sys(build), osmesa-src(buil
error[E0432]: unresolved import `webxr_api::EnvironmentBlendMode`
  --> components/script/dom/xrsession.rs:53:11
   |
53 |     self, EnvironmentBlendMode, Event as XREvent, Frame, SelectEvent, Session, Visibility,
   |           ^^^^^^^^^^^^^^^^^^^^ no `EnvironmentBlendMode` in the root

error[E0599]: no method named `environment_blend_mode` found for type `webxr_api::session::Session` in the current scope
  --> components/script/dom/xrsession.rs:91:33
   |
91 |             blend_mode: session.environment_blend_mode().into(),
   |                                 ^^^^^^^^^^^^^^^^^^^^^^ method not found in `webxr_api::session::Session`

error: aborting due to 2 previous errors

Some errors have detailed explanations: E0432, E0599.
For more information about an error, try `rustc --explain E0432`.
error: could not compile `script`.

To learn more, run the command again with --verbose.
Build FAILED in 0:23:28

Then, I opened Cargo.lock and observed the commit hash id of webxr-api is changed back to the old one. The most interesting thing was, I didn't see the hash change on terminal but on VSCode. 🤔

After checkout the hash id to the latest one, I can build Servo successfully 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.