Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update servo-media. Temporarily disable progressive download on Android #24444

Merged
merged 1 commit into from Oct 16, 2019
Merged

Update servo-media. Temporarily disable progressive download on Android #24444

merged 1 commit into from Oct 16, 2019
+12 −12

Conversation

@ferjm
Copy link
Member

ferjm commented Oct 14, 2019

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #24413
@ferjm
Update servo-media. Temporarily disable progressive download on Android
Loading status checks…
9d7d410
@ferjm
Copy link
Member Author

ferjm commented Oct 14, 2019

r? @jdm
@highfive highfive assigned jdm and unassigned asajeffrey Oct 14, 2019
@jdm
Copy link
Member

jdm commented Oct 15, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Oct 15, 2019

📌 Commit 9d7d410 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Oct 16, 2019

⌛ Testing commit 9d7d410 with merge 3266489...
bors-servo added a commit that referenced this pull request Oct 16, 2019
@bors-servo
Auto merge of #24444 - ferjm:downloadbuffer.android, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3266489 
Update servo-media. Temporarily disable progressive download on Android

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #24413
@bors-servo
Copy link
Contributor

bors-servo commented Oct 16, 2019

💔 Test failed - linux-rel-wpt
@CYBAI
Copy link
Collaborator

CYBAI commented Oct 16, 2019

@bors-servo retry

  ▶ Unexpected subtest result in /css/css-text/white-space/trailing-space-position-001.html:
  │ FAIL [expected PASS] CSS Test: Positions of trailing collapsible spaces 4
  │   → assert_equals: expected 0 but got -0
  │ 
  │ @http://web-platform.test:8000/css/css-text/white-space/trailing-space-position-001.html:37:5
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1908:25
  │ test@http://web-platform.test:8000/resources/testharness.js:544:30
  └ @http://web-platform.test:8000/css/css-text/white-space/trailing-space-position-001.html:35:3
@bors-servo
Copy link
Contributor

bors-servo commented Oct 16, 2019

💣 Failed to start rebuilding: Unknown error
@bors-servo
Copy link
Contributor

bors-servo commented Oct 16, 2019

⌛ Testing commit 9d7d410 with merge c071e8c...
bors-servo added a commit that referenced this pull request Oct 16, 2019
@bors-servo
Auto merge of #24444 - ferjm:downloadbuffer.android, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c071e8c 
Update servo-media. Temporarily disable progressive download on Android

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #24413
@bors-servo
Copy link
Contributor

bors-servo commented Oct 16, 2019

💔 Test failed - linux-rel-wpt
@CYBAI
Copy link
Collaborator

CYBAI commented Oct 16, 2019

Interesting.We got the same failure as #24435. Maybe we need to clean the virtualenv on buildbots first like @jdm said?
@jdm
Copy link
Member

jdm commented Oct 16, 2019

@bors-servo retry
Should be queued after #24435
@bors-servo
Copy link
Contributor

bors-servo commented Oct 16, 2019

⌛ Testing commit 9d7d410 with merge f262f62...
bors-servo added a commit that referenced this pull request Oct 16, 2019
@bors-servo
Auto merge of #24444 - ferjm:downloadbuffer.android, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f262f62 
Update servo-media. Temporarily disable progressive download on Android

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #24413
@bors-servo
Copy link
Contributor

bors-servo commented Oct 16, 2019

💔 Test failed - linux-rel-css
@jdm
Copy link
Member

jdm commented Oct 16, 2019

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Oct 16, 2019

💣 Failed to start rebuilding: Unknown error
@bors-servo
Copy link
Contributor

bors-servo commented Oct 16, 2019

⌛ Testing commit 9d7d410 with merge b5759e7...
bors-servo added a commit that referenced this pull request Oct 16, 2019
@bors-servo
Auto merge of #24444 - ferjm:downloadbuffer.android, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b5759e7 
Update servo-media. Temporarily disable progressive download on Android

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #24413
@bors-servo
Copy link
Contributor

bors-servo commented Oct 16, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: jdm
Pushing b5759e7 to master...
@bors-servo bors-servo merged commit 9d7d410 into servo:master Oct 16, 2019
3 checks passed
3 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Media playback is broken on Android
6 participants
@ferjm @jdm @bors-servo @CYBAI @asajeffrey @highfive
You can’t perform that action at this time.