Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around deprecation warnings caused by autocfg $RUSTFLAGS handling #24447

Merged
merged 2 commits into from Oct 16, 2019
Merged

Work around deprecation warnings caused by autocfg $RUSTFLAGS handling #24447

merged 2 commits into from Oct 16, 2019

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented Oct 15, 2019

See #24446
@SimonSapin
Work around deprecation warnings caused by autocfg $RUSTFLAGS handling
Loading status checks…
6ef9d34 
See #24446
@highfive
Copy link

highfive commented Oct 15, 2019

Heads up! This PR modifies the following files:
@nox
Copy link
Member

nox commented Oct 15, 2019

Lol.

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Oct 15, 2019

📌 Commit 6ef9d34 has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Oct 15, 2019

⌛ Testing commit 6ef9d34 with merge cd698f5...
bors-servo added a commit that referenced this pull request Oct 15, 2019
@bors-servo
Auto merge of #24447 - servo:uninit, r=nox
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
cd698f5 
Work around deprecation warnings caused by autocfg $RUSTFLAGS handling

See #24446
@bors-servo
Copy link
Contributor

bors-servo commented Oct 15, 2019

💔 Test failed - status-taskcluster
@SimonSapin
Copy link
Member Author

SimonSapin commented Oct 15, 2019

All Windows tasks failed to create a virtualenv:

    distutils.errors.DistutilsPlatformError: Microsoft Visual C++ 9.0 is required. Get it from http://aka.ms/vcpython27

… which appears unrelated to this PR.
@SimonSapin
Copy link
Member Author

SimonSapin commented Oct 15, 2019 •
edited

https://pypi.org/project/cffi/#files currently says that cffi-1.13.0-cp27-cp27m-win32.whl was uploaded “about an hour ago” while cffi-1.13.0.tar.gz was uploaded “about 4 hours ago”. It seems plausible that our builds usually find a pre-compiled CFFI, but this one happened just at the time where it wasn’t available and our Windows AMI doesn’t have everything needed to compile CPython 2.7 extension modules from source.

@bors-servo retry
@jdm
Copy link
Member

jdm commented Oct 15, 2019

The same error occurred on the windows nightly runs.
@SimonSapin
Fix #24446
Loading status checks…
e0e1d9d
@SimonSapin
Copy link
Member Author

SimonSapin commented Oct 15, 2019

Added a commit to patch the autocfg crate
@jdm
Copy link
Member

jdm commented Oct 15, 2019

@bors-servo r=nox
@bors-servo
Copy link
Contributor

bors-servo commented Oct 15, 2019

📌 Commit e0e1d9d has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Oct 16, 2019

⌛ Testing commit e0e1d9d with merge 056e650...
bors-servo added a commit that referenced this pull request Oct 16, 2019
@bors-servo
Auto merge of #24447 - servo:uninit, r=nox
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
056e650 
Work around deprecation warnings caused by autocfg $RUSTFLAGS handling

See #24446
@bors-servo
Copy link
Contributor

bors-servo commented Oct 16, 2019

💔 Test failed - status-taskcluster
@CYBAI
Copy link
Collaborator

CYBAI commented Oct 16, 2019

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Oct 16, 2019

💔 Test failed - status-taskcluster
@CYBAI
Copy link
Collaborator

CYBAI commented Oct 16, 2019

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Oct 16, 2019

⌛ Testing commit e0e1d9d with merge 43408c7...
bors-servo added a commit that referenced this pull request Oct 16, 2019
@bors-servo
Auto merge of #24447 - servo:uninit, r=nox
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
43408c7 
Work around deprecation warnings caused by autocfg $RUSTFLAGS handling

See #24446
@bors-servo
Copy link
Contributor

bors-servo commented Oct 16, 2019

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented Oct 16, 2019

@bors-servo retry

  • Network issue
@bors-servo
Copy link
Contributor

bors-servo commented Oct 16, 2019

⌛ Testing commit e0e1d9d with merge 5bd479f...
bors-servo added a commit that referenced this pull request Oct 16, 2019
@bors-servo
Auto merge of #24447 - servo:uninit, r=nox
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5bd479f 
Work around deprecation warnings caused by autocfg $RUSTFLAGS handling

See #24446
@bors-servo
Copy link
Contributor

bors-servo commented Oct 16, 2019

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented Oct 16, 2019

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Oct 16, 2019

⌛ Testing commit e0e1d9d with merge 9032207...
bors-servo added a commit that referenced this pull request Oct 16, 2019
@bors-servo
Auto merge of #24447 - servo:uninit, r=nox
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9032207 
Work around deprecation warnings caused by autocfg $RUSTFLAGS handling

See #24446
@bors-servo
Copy link
Contributor

bors-servo commented Oct 16, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: nox
Pushing 9032207 to master...
@bors-servo bors-servo merged commit e0e1d9d into master Oct 16, 2019
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
Taskcluster (pull_request) TaskGroup: success
Details
homu Test successful
Details
@bors-servo bors-servo deleted the uninit branch Oct 16, 2019
@bors-servo bors-servo mentioned this pull request Oct 16, 2019
Closed
0 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@SimonSapin @highfive @nox @bors-servo @jdm @CYBAI
You can’t perform that action at this time.