Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw when failing to convert sequence inner values #24455

Merged
merged 1 commit into from Oct 17, 2019
Merged

Throw when failing to convert sequence inner values #24455

merged 1 commit into from Oct 17, 2019

Conversation

@saschanaz
Copy link
Contributor

saschanaz commented Oct 16, 2019 •
edited

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #24406
  • There are tests for these changes
@highfive
Copy link

highfive commented Oct 16, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/bindings/codegen/CodegenRust.py, components/script/Cargo.toml
  • @KiChjang: components/script/dom/bindings/codegen/CodegenRust.py, components/script/Cargo.toml
@highfive
Copy link

highfive commented Oct 16, 2019

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@saschanaz
Copy link
Contributor Author

saschanaz commented Oct 16, 2019

@bors-servo try=wpt
@bors-servo
Copy link
Contributor

bors-servo commented Oct 16, 2019

⌛ Trying commit e7aead7 with merge 44840c7...
bors-servo added a commit that referenced this pull request Oct 16, 2019
@bors-servo
Auto merge of #24455 - saschanaz:sequence-strict, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
44840c7 
[WIP] Match sequence only when the value is iterable

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #24406

<!-- Either: -->
- [ ] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 16, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
State: approved= try=True
@saschanaz saschanaz force-pushed the saschanaz:sequence-strict branch from e7aead7 to 13d4e5e Oct 16, 2019
@servo-wpt-sync servo-wpt-sync mentioned this pull request Oct 16, 2019
Merged
@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented Oct 16, 2019

Opened new PR for upstreamable changes.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#19726.
@jdm
Copy link
Member

jdm commented Oct 16, 2019

Needs a mach update-manifest.
@saschanaz saschanaz force-pushed the saschanaz:sequence-strict branch 2 times, most recently from c1f5d7c to a077710 Oct 16, 2019
@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented Oct 16, 2019

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#19726.
@saschanaz saschanaz changed the title [WIP] Match sequence only when the value is iterable Throw when failing to convert sequence inner values Oct 16, 2019
@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented Oct 16, 2019

PR title changed; changed existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#19726.
@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented Oct 16, 2019

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#19726.
@jdm
jdm reviewed Oct 16, 2019
View changes
tests/wpt/web-platform-tests/url/urlsearchparams-constructor.any.js Outdated Show resolved Hide resolved
@jdm jdm assigned jdm and unassigned paulrouget Oct 16, 2019
@saschanaz
Throw when failing to convert sequence inner values
Loading status checks…
6c98292
@saschanaz saschanaz force-pushed the saschanaz:sequence-strict branch from a077710 to 6c98292 Oct 17, 2019
@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented Oct 17, 2019

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#19726.
@jdm
Copy link
Member

jdm commented Oct 17, 2019

@bors-servo r+
Thanks!
@bors-servo
Copy link
Contributor

bors-servo commented Oct 17, 2019

📌 Commit 6c98292 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Oct 17, 2019

⌛ Testing commit 6c98292 with merge 9728484...
bors-servo added a commit that referenced this pull request Oct 17, 2019
@bors-servo
Auto merge of #24455 - saschanaz:sequence-strict, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9728484 
Throw when failing to convert sequence inner values

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #24406

<!-- Either: -->
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 17, 2019

💔 Test failed - linux-rel-wpt
@saschanaz
Copy link
Contributor Author

saschanaz commented Oct 17, 2019

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Oct 17, 2019

⌛ Testing commit 6c98292 with merge 3ba5ad7...
bors-servo added a commit that referenced this pull request Oct 17, 2019
@bors-servo
Auto merge of #24455 - saschanaz:sequence-strict, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3ba5ad7 
Throw when failing to convert sequence inner values

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #24406

<!-- Either: -->
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 17, 2019

💔 Test failed - linux-rel-css
@jdm
Copy link
Member

jdm commented Oct 17, 2019

@bors-servo retry
bors-servo added a commit that referenced this pull request Oct 17, 2019
@bors-servo
Auto merge of #24455 - saschanaz:sequence-strict, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5b696bb 
Throw when failing to convert sequence inner values

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #24406

<!-- Either: -->
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 17, 2019

⌛ Testing commit 6c98292 with merge 5b696bb...
@bors-servo
Copy link
Contributor

bors-servo commented Oct 17, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: jdm
Pushing 5b696bb to master...
@bors-servo bors-servo merged commit 6c98292 into servo:master Oct 17, 2019
2 checks passed
2 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdm jdm

Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

URLSearchParams constructor interprets an array as a record
6 participants
@saschanaz @highfive @bors-servo @servo-wpt-sync @jdm @paulrouget
You can’t perform that action at this time.