Performance interface's timing member as an attribute change

[tomasdivito]

In this patch we change the Performance Interface's timing member to be an attribute as the spec requires: https://w3c.github.io/navigation-timing/#extensions-to-the-performance-interface

• ./mach build -d does not report any errors
• ./mach test-tidy does not report any errors
• These changes fix #23330

---

• There are tests for these changes OR
• These changes do not require tests because ___

[highfive]

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @jdm (or someone else) soon.

[highfive]

Heads up! This PR modifies the following files:

• @asajeffrey: components/script/dom/webidls/Performance.webidl
• @KiChjang: components/script/dom/webidls/Performance.webidl

[highfive]

Warning

• These commits modify script code, but no tests are modified. Please consider adding a test!

[tomasdivito]

I have yet to check but I believe some tests are broken or at least it gave me that impression when I tried ./mach test-wpt tests/wpt/web-platform-tests/navigation-timing/

[jdm]

@bors-servo try=wpt

[bors-servo]

⌛ Trying commit 4ba031c with merge 1de5e4d...

[bors-servo]

💔 Test failed - linux-rel-css

[tomasdivito]

@jdm I'm taking a look at the comments you made here: #23773

when you talk about the panicked test, I believe you meant this:
./mach test-wpt tests/wpt/mozilla/tests/mozilla/window_performance.html
instead of
./mach test-wpt tests/wpt/mozilla/window_performance.html which reports "CRITICAL Unable to find any tests at the path(s)"

Having this in mind, we are currently facing the same issue? Am I right? If that's the case, the solution you proposed should be filled in another issue and worked apart from this one (I can take that, would be nice to work on) but not sure if that would be the steps to follow

[jdm]

Yes, this is the same issue that I described. Given the number of additional passing tests in https://build.servo.org/builders/linux-rel-wpt/builds/13812/steps/shell__4/logs/filtered-wpt-errorsummary.log I am happy to merge these changes and file that issue separately.

[jdm]

Filed #24468.

[jdm]

I recommend running the affected test directories and using these instructions to generate logs you can use to automatically update the expected test results.

[jdm]

@tomasdivito Are you planning to finish this PR?

[tomasdivito]

@jdm Yes, or at least when #24468 is done.

If I don't make progress this weekend I'll report it and remove the assignation. If you think this / or the other patch should have more priority feel free to un-assign me if that's the case

[bors-servo]

☔ The latest upstream changes (presumably #25205) made this pull request unmergeable. Please resolve the merge conflicts.

[CYBAI]

Close in favor of #25205