Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUse surfman for managing GL surfaces #24482
Merged
Conversation
highfive
commented
Oct 17, 2019
|
Heads up! This PR modifies the following files:
|
highfive
commented
Oct 17, 2019
|
|
|
I skimmed a lot of webgl_thread.rs but overall this looks like it's in good shape. |
|
@bors-servo try |
|
|
|
@bors-servo try |
bors-servo
added a commit
that referenced
this pull request
Oct 17, 2019
Use surfman for managing GL surfaces <!-- Please describe your changes on the following line: --> Replaces texture sharing with surfman surface sharing. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #23509 and #24256 - [x] These changes do not require tests because this is backend gfx <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
|
Most comments addressed, the outstanding one is about depth/stencil/alpha. |
|
Build failures are caused by the warnings caused by WebVR not being implemented. |
|
@bors-servo try |
bors-servo
added a commit
that referenced
this pull request
Oct 17, 2019
Use surfman for managing GL surfaces <!-- Please describe your changes on the following line: --> Replaces texture sharing with surfman surface sharing. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #23509 and #24256 - [x] These changes do not require tests because this is backend gfx <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
|
The android build is failing because something is causing a |
|
Also be aware: the WPT tests on linux had a lot of failures: https://build.servo.org/builders/linux-rel-css/builds/13780 |
|
They're all crashes of: |
|
Squashed. @bors-servo r=jdm |
|
|
bors-servo
added a commit
that referenced
this pull request
Nov 1, 2019
Use surfman for managing GL surfaces <!-- Please describe your changes on the following line: --> Replaces texture sharing with surfman surface sharing. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #23509 and #24256 - [x] These changes do not require tests because this is backend gfx <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
|
@bors-servo retry force |
|
|
bors-servo
added a commit
that referenced
this pull request
Nov 1, 2019
Use surfman for managing GL surfaces <!-- Please describe your changes on the following line: --> Replaces texture sharing with surfman surface sharing. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #23509 and #24256 - [x] These changes do not require tests because this is backend gfx <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
This was referenced Nov 1, 2019
Closed
This was referenced Nov 1, 2019
This was referenced Nov 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
asajeffrey commentedOct 17, 2019
Replaces texture sharing with surfman surface sharing.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors