Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media Session API #24499

Merged
merged 37 commits into from Nov 20, 2019
Merged

Media Session API #24499

merged 37 commits into from Nov 20, 2019

Conversation

@ferjm
Copy link
Member

ferjm commented Oct 18, 2019 •
edited

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #24172
  • There are tests for these changes

This PR introduces all the pieces required to prove an end to end media session flow with Android as a test platform.
@highfive
Copy link

highfive commented Oct 18, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/navigator.rs, components/script/dom/mod.rs, components/script/dom/mediasession.rs, components/script/dom/webidls/MediaMetadata.webidl, components/script/dom/htmlmediaelement.rs and 5 more
  • @cbrewster: components/constellation/constellation.rs
  • @KiChjang: components/script/dom/navigator.rs, components/script/dom/mod.rs, components/script/dom/mediasession.rs, components/script_traits/lib.rs, components/script/dom/webidls/MediaMetadata.webidl and 5 more
@highfive
Copy link

highfive commented Oct 18, 2019

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify script code, but no tests are modified. Please consider adding a test!
@gterzian
gterzian reviewed Oct 20, 2019
View changes
components/script/dom/mediasession.rs Outdated Show resolved Hide resolved
@gterzian
gterzian reviewed Oct 20, 2019
View changes
components/script/script_thread.rs Outdated Show resolved Hide resolved
@gterzian
gterzian reviewed Oct 20, 2019
View changes
components/script/script_thread.rs Outdated Show resolved Hide resolved
@gterzian
gterzian reviewed Oct 20, 2019
View changes
ports/libsimpleservo/api/src/lib.rs Outdated Show resolved Hide resolved
@gterzian
gterzian reviewed Oct 20, 2019
View changes
components/servo/lib.rs Outdated Show resolved Hide resolved
@jdm
Copy link
Member

jdm commented Oct 24, 2019

r? @Manishearth
@highfive highfive assigned Manishearth and unassigned jdm Oct 24, 2019
@Manishearth
Manishearth approved these changes Oct 29, 2019
View changes
Copy link
Member

Manishearth left a comment

looks good overall!

@gterzian's suggestion for making it a global thing might be useful. Unsure how to structure that.
components/script/dom/mediasession.rs Outdated Show resolved Hide resolved
components/script/dom/mediasession.rs Outdated Show resolved Hide resolved
components/script/dom/mediasession.rs Outdated Show resolved Hide resolved
ports/libsimpleservo/api/src/lib.rs Outdated Show resolved Hide resolved
components/embedder_traits/lib.rs Outdated Show resolved Hide resolved
components/script/dom/htmlmediaelement.rs Outdated Show resolved Hide resolved
@ferjm ferjm force-pushed the ferjm:media.session.api branch from 16f7833 to fce9e94 Nov 15, 2019
@ferjm ferjm changed the title [WIP] Media Session API Media Session API Nov 18, 2019
@ferjm
Copy link
Member Author

ferjm commented Nov 18, 2019

@bors-servo try
bors-servo added a commit that referenced this pull request Nov 18, 2019
@bors-servo
Auto merge of #24499 - ferjm:media.session.api, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
129012d 
Media Session API

- [X] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #24172
- [x] There are tests for these changes

This PR introduces all the pieces required to prove an end to end media session flow with Android as a test platform. It is still not very functional and WIP though.
@bors-servo
Copy link
Contributor

bors-servo commented Nov 18, 2019

⌛ Trying commit 83969c9 with merge 129012d...
@ferjm
Copy link
Member Author

ferjm commented Nov 18, 2019

r? @Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Nov 18, 2019

💔 Test failed - status-taskcluster
@Manishearth
Copy link
Member

Manishearth commented Nov 18, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Nov 18, 2019

📌 Commit 83969c9 has been approved by Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Nov 18, 2019

⌛ Testing commit 83969c9 with merge 33f4d2a...
bors-servo added a commit that referenced this pull request Nov 18, 2019
@bors-servo
Auto merge of #24499 - ferjm:media.session.api, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
33f4d2a 
Media Session API

- [X] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #24172
- [x] There are tests for these changes

This PR introduces all the pieces required to prove an end to end media session flow with Android as a test platform. It is still not very functional and WIP though.
@bors-servo
Copy link
Contributor

bors-servo commented Nov 18, 2019

💔 Test failed - linux-rel-wpt
ferjm added 3 commits Nov 19, 2019
@ferjm
Update test expectations
ca1a2e0
@ferjm
Fix simpleservo build
6dcdfef
@ferjm
Mach fmt, this time including C++ files
Loading status checks…
9f77ea1
@ferjm ferjm force-pushed the ferjm:media.session.api branch from 271fc9b to 9f77ea1 Nov 20, 2019
@ferjm
Copy link
Member Author

ferjm commented Nov 20, 2019

@bors-servo r=Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Nov 20, 2019

📌 Commit 9f77ea1 has been approved by Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Nov 20, 2019

⌛ Testing commit 9f77ea1 with merge 48f6511...
bors-servo added a commit that referenced this pull request Nov 20, 2019
@bors-servo
Auto merge of #24499 - ferjm:media.session.api, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
48f6511 
Media Session API

- [X] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #24172
- [x] There are tests for these changes

This PR introduces all the pieces required to prove an end to end media session flow with Android as a test platform.
@bors-servo
Copy link
Contributor

bors-servo commented Nov 20, 2019

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented Nov 20, 2019

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Nov 20, 2019

💣 Failed to start rebuilding: 405 Not Allowed
@bors-servo
Copy link
Contributor

bors-servo commented Nov 20, 2019

⌛ Testing commit 9f77ea1 with merge f6348b8...
bors-servo added a commit that referenced this pull request Nov 20, 2019
@bors-servo
Auto merge of #24499 - ferjm:media.session.api, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f6348b8 
Media Session API

- [X] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #24172
- [x] There are tests for these changes

This PR introduces all the pieces required to prove an end to end media session flow with Android as a test platform.
@bors-servo
Copy link
Contributor

bors-servo commented Nov 20, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: Manishearth
Pushing f6348b8 to master...
@bors-servo bors-servo merged commit 9f77ea1 into servo:master Nov 20, 2019
1 of 2 checks passed
1 of 2 checks passed
Community-TC (pull_request) TaskGroup: failure
Details
homu Test successful
Details
This was referenced Nov 20, 2019
Merged
Merged
@ferjm ferjm mentioned this pull request Nov 21, 2019
Closed
@ferjm ferjm added this to Done in Media playback Nov 21, 2019
@ferjm ferjm mentioned this pull request Nov 21, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gterzian gterzian

@Manishearth Manishearth

Assignees

@Manishearth Manishearth

Labels
None yet
Projects
Media playback
  
Done
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Media Session API
6 participants
@ferjm @highfive @jdm @bors-servo @Manishearth @gterzian
You can’t perform that action at this time.