Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass source origin in MessageEvent. #24526

Closed
wants to merge 1 commit into from

Conversation

@mmiecz
Copy link
Contributor

mmiecz commented Oct 23, 2019

Add source origin to message event.
This PR makes tests/wpt/web-platform-tests/dom/events/EventListener-incumbent-global-1.sub.html to pass


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #22888 (GitHub issue number if applicable)
  • There are tests for these changes OR
  • These changes do not require tests because ___
@highfive
Copy link

highfive commented Oct 23, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/constellation/constellation.rs, components/script/dom/dissimilaroriginwindow.rs, components/script/script_thread.rs, components/script/dom/window.rs
  • @cbrewster: components/constellation/constellation.rs
  • @KiChjang: components/script_traits/script_msg.rs, components/script/dom/dissimilaroriginwindow.rs, components/script/script_thread.rs, components/script/dom/window.rs, components/script_traits/lib.rs
@highfive
Copy link

highfive commented Oct 23, 2019

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@jdm
Copy link
Member

jdm commented Oct 23, 2019

This needs to be rebased against a recent master. I suspect that #23637 has merged and caused conflicts.

@mmiecz
Copy link
Contributor Author

mmiecz commented Oct 24, 2019

As @gterzian said here: #22888 (comment) this is already done, so I'm closing this PR.

@mmiecz mmiecz closed this Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.