Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upLaunch UWP app from command line #24534
Merged
Conversation
|
r? @paulrouget |
|
Aren't we gonna lose the |
|
Yes. I just fixed it with the last commit. |
|
Works well :) Thank you. @bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 25, 2019
Launch UWP app from command line - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors This PR makes it possible to launch the UWP app from the command line by executing (on any path) the `Servo` command. It requires building and launching Servo once on VS, so the command alias is properly registered. It also allows passing command line arguments. So we can do for example `Servo --pref dom.webxr.enabled`. Debugging is also possible when launching the app from the command line. It requires setting the `Launch Application` option (right click on `ServoApp (Universal Windows`) on the Solution Explorer view -> Properties -> Configuration Properties -> Debugging) to `No`.
|
|
|
@bors-servo retry |
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 25, 2019
Launch UWP app from command line - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors This PR makes it possible to launch the UWP app from the command line by executing (on any path) the `Servo` command. It requires building and launching Servo once on VS, so the command alias is properly registered. It also allows passing command line arguments. So we can do for example `Servo --pref dom.webxr.enabled`. Debugging is also possible when launching the app from the command line. It requires setting the `Launch Application` option (right click on `ServoApp (Universal Windows`) on the Solution Explorer view -> Properties -> Configuration Properties -> Debugging) to `No`.
|
|
This was referenced Oct 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ferjm commentedOct 24, 2019
•
edited
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis PR makes it possible to launch the UWP app from the command line by executing (on any path) the
Servocommand. It requires building and launching Servo once on VS, so the command alias is properly registered.It also allows passing command line arguments. So we can do for example
Servo --pref dom.webxr.enabled.Debugging is also possible when launching the app from the command line. It requires setting the
Launch Applicationoption (right click onServoApp (Universal Windows) on the Solution Explorer view -> Properties -> Configuration Properties -> Debugging) toNo.