Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate UWP ANGLE to a modern version #24542
Merged
+14
−18
Conversation
highfive
commented
Oct 24, 2019
|
Heads up! This PR modifies the following files:
|
|
r? @paulrouget |
|
In the new Angle package, the library name changed from |
|
Getting this error while compiling the VS project: |
|
Whoops; some local changes I made didn't get added to the PR. |
|
Verified locally that these changes compiled. |
|
Works as expected. @bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 28, 2019
Update UWP ANGLE to a modern version The previous UWP ANGLE builds were made from https://github.com/servo/ms-angle/tree/servo-master which was based on an abandoned revision of ANGLE from >2 years ago. This is lacking some features that are necessary for servo/webxr#46, so this is a new build produced from https://github.com/google/angle/ instead. I've documented the process for releasing new ANGLE builds at https://github.com/servo/servo/wiki/Publishing-a-new-ANGLE-NuGet-version. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #24199 - [x] These changes do not require tests because the windows testing situation is sad, and the UWP testing situation is sadder
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 29, 2019
Fix GL panic with updated ANGLE Our OES_texture_float extension implementation relied on the GL implementation to convert from unsized formats like RGBA when using the FLOAT/HALF_FLOAT type to an internal sized format that was acceptable. ANGLE no longer appears to do that since #24542, so we should enable the format conversion unconditionally. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #24578 - [x] There are tests for these changes
bors-servo
added a commit
that referenced
this pull request
Oct 29, 2019
Fix GL panic with updated ANGLE Our OES_texture_float extension implementation relied on the GL implementation to convert from unsized formats like RGBA when using the FLOAT/HALF_FLOAT type to an internal sized format that was acceptable. ANGLE no longer appears to do that since #24542, so we should enable the format conversion unconditionally. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #24578 - [x] There are tests for these changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jdm commentedOct 24, 2019
•
edited
The previous UWP ANGLE builds were made from https://github.com/servo/ms-angle/tree/servo-master which was based on an abandoned revision of ANGLE from >2 years ago. This is lacking some features that are necessary for servo/webxr#46, so this is a new build produced from https://github.com/google/angle/ instead.
I've documented the process for releasing new ANGLE builds at https://github.com/servo/servo/wiki/Publishing-a-new-ANGLE-NuGet-version.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors