Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UWP: better mouse interaction support #24547

Merged
merged 1 commit into from Oct 29, 2019
Merged

UWP: better mouse interaction support #24547

merged 1 commit into from Oct 29, 2019
+101 −14

Conversation

@paulrouget
Copy link
Contributor

paulrouget commented Oct 25, 2019 •
edited

No description provided.

@bors-servo
Copy link
Contributor

bors-servo commented Oct 25, 2019

☔ The latest upstream changes (presumably #24534) made this pull request unmergeable. Please resolve the merge conflicts.
@jdm
Copy link
Member

jdm commented Oct 25, 2019

I filed #24530 after observing it in a desktop glutin window - are there similar changes we need to make to that port as well?
@paulrouget
Copy link
Contributor Author

paulrouget commented Oct 28, 2019

I filed #24530 after observing it in a desktop glutin window - are there similar changes we need to make to that port as well?

Good to know. This is actually a different issue with the pointer event polyfil. Which I worked around in the latest bbjs demo update.

This PR doesn't fix this issue for desktop, but does fix the behavior for UWP builds.
@paulrouget
Copy link
Contributor Author

paulrouget commented Oct 28, 2019

The bbjs demos now use a better workaround for #24363. The double click issue (#24530) doesn't exist anymore.

But still need that fix for the non-glutin port.
@paulrouget paulrouget force-pushed the paulrouget:click branch from 0223cf2 to 015d95c Oct 28, 2019
@jdm
jdm requested changes Oct 28, 2019
View changes
support/hololens/ServoApp/ServoControl/ServoControl.cpp Outdated Show resolved Hide resolved
@paulrouget paulrouget force-pushed the paulrouget:click branch from 015d95c to 548231d Oct 29, 2019
@paulrouget
UWP: better mouse interaction support
Loading status checks…
f2f8223
@paulrouget paulrouget force-pushed the paulrouget:click branch from 548231d to f2f8223 Oct 29, 2019
@jdm
Copy link
Member

jdm commented Oct 29, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Oct 29, 2019

📌 Commit f2f8223 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Oct 29, 2019

⌛ Testing commit f2f8223 with merge e290e5f...
bors-servo added a commit that referenced this pull request Oct 29, 2019
@bors-servo
Auto merge of #24547 - paulrouget:click, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e290e5f 
UWP: better mouse interaction support
@bors-servo
Copy link
Contributor

bors-servo commented Oct 29, 2019

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented Oct 29, 2019

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Oct 29, 2019

⌛ Testing commit f2f8223 with merge 571dc12...
bors-servo added a commit that referenced this pull request Oct 29, 2019
@bors-servo
Auto merge of #24547 - paulrouget:click, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
571dc12 
UWP: better mouse interaction support
@bors-servo
Copy link
Contributor

bors-servo commented Oct 29, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: jdm
Pushing 571dc12 to master...
@bors-servo bors-servo merged commit f2f8223 into servo:master Oct 29, 2019
2 checks passed
2 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Oct 29, 2019
Merged
@Manishearth Manishearth mentioned this pull request Nov 8, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdm jdm

Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@paulrouget @bors-servo @jdm @highfive
You can’t perform that action at this time.