Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpgrade SpiderMonkey #2455
Closed
Upgrade SpiderMonkey #2455
Conversation
highfive
commented
May 16, 2014
|
|
hoppipolla-critic-bot
commented
May 16, 2014
|
Critic review: https://critic.hoppipolla.co.uk/r/1585 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
Needs servo/rust-mozjs#82, obviously. |
| } | ||
| with_compartment(cx, obj, || { | ||
| JS_InitStandardClasses(cx, obj); | ||
| CompartmentOptions_SetVersion(cx, JSVERSION_LATEST); | ||
| CompartmentOptions_SetTraceGlobal(cx, Some(WindowBinding::_trace)); |
This comment has been minimized.
This comment has been minimized.
jdm
May 16, 2014
Author
Member
Note to self: the trace hook never appears to be called, so this is likely broken.
src/components/script/script_task.rs
Outdated
| let ConstellationChan(const_chan) = constellation_chan.clone(); | ||
| send_on_failure(&mut builder, FailureMsg(failure_msg), const_chan); | ||
| builder.spawn(proc() { | ||
| //send_on_failure(&mut builder, FailureMsg(failure_msg), const_chan); |
This comment has been minimized.
This comment has been minimized.
jdm
May 16, 2014
Author
Member
Note to self: still need to replicate send_on_failure for native tasks
|
No real point in leaving this PR open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jdm commentedMay 16, 2014
I'm opening this up to make it easier for other people to review and discuss changes. All tests pass, which is something (even wpt, except for a timeout in dom/nodes/case.htm that I need help with).