Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a ridiculous bug in layout-2020 #24551

Merged
merged 1 commit into from Oct 25, 2019
Merged

Fix a ridiculous bug in layout-2020 #24551

merged 1 commit into from Oct 25, 2019

Conversation

@nox
Copy link
Member

nox commented Oct 25, 2019

Who needs CI anyway?
@nox
Fix a ridiculous bug in layout-2020
Loading status checks…
327740d 
Who needs CI anyway?
@highfive
Copy link

highfive commented Oct 25, 2019

Heads up! This PR modifies the following files:

  • @jgraham: tests/wpt/metadata-layout-2020/css/CSS2/box-display/containing-block-021.xht.ini, tests/wpt/metadata-layout-2020/css/CSS2/box-display/block-in-inline-001.xht.ini, tests/wpt/metadata-layout-2020/css/CSS2/box-display/delete-block-in-inlines-middle-001.xht.ini, tests/wpt/metadata-layout-2020/css/CSS2/box-display/insert-block-in-blocks-n-inlines-begin-001.xht.ini, tests/wpt/metadata-layout-2020/css/CSS2/box-display/insert-inline-in-blocks-n-inlines-end-003.xht.ini and 84 more
@SimonSapin
Copy link
Member

SimonSapin commented Oct 25, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Oct 25, 2019

📌 Commit 327740d has been approved by SimonSapin
@highfive highfive assigned SimonSapin and unassigned ferjm Oct 25, 2019
@bors-servo
Copy link
Contributor

bors-servo commented Oct 25, 2019

⌛ Testing commit 327740d with merge 45113a6...
bors-servo added a commit that referenced this pull request Oct 25, 2019
@bors-servo
Auto merge of #24551 - nox:i-am-very-smart, r=SimonSapin
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
45113a6 
Fix a ridiculous bug in layout-2020

Who needs CI anyway?
@bors-servo
Copy link
Contributor

bors-servo commented Oct 25, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: SimonSapin
Pushing 45113a6 to master...
@bors-servo bors-servo merged commit 327740d into servo:master Oct 25, 2019
2 checks passed
2 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
homu Test successful
Details
@SimonSapin SimonSapin added this to Done / resolved in Layout 2020 Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SimonSapin SimonSapin

Labels
A-layout/2020
Projects
Layout 2020
  
Merged / resolved
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@nox @highfive @SimonSapin @bors-servo @ferjm
You can’t perform that action at this time.