Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to rustc 1.40.0-nightly (246be7e1a 2019-10-25) #24557

Merged
merged 3 commits into from Oct 28, 2019
Merged

Upgrade to rustc 1.40.0-nightly (246be7e1a 2019-10-25) #24557

merged 3 commits into from Oct 28, 2019

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented Oct 26, 2019

No description provided.

SimonSapin added 2 commits Oct 26, 2019
@SimonSapin
Move items at the root of the script crate to a module
642b8b0
@SimonSapin
Upgrade to rustc 1.40.0-nightly (246be7e1a 2019-10-25)
Loading status checks…
d3439fb
@highfive
Copy link

highfive commented Oct 26, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/lib.rs, components/script/init.rs
  • @KiChjang: components/script/lib.rs, components/script/init.rs
@highfive
Copy link

highfive commented Oct 26, 2019

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify script code, but no tests are modified. Please consider adding a test!
@jdm
Copy link
Member

jdm commented Oct 26, 2019

script_plugins isn't building correctly.
@SimonSapin
Copy link
Member Author

SimonSapin commented Oct 27, 2019

This is because compiler crates used by compiler plugins have been moved out of the rust-std component in rustup and into a new rustc-dev component. I’ve pushed another commit to install that.
@jdm
Copy link
Member

jdm commented Oct 27, 2019

The scrupt_plugins for the taskcluster tidy/unit job is still broken.
@SimonSapin
Taskcluster: install the `rustc-dev` rustup component, required for c…
Loading status checks…
6ba0fab 
…ompiler plugins
@SimonSapin SimonSapin force-pushed the rustup branch from 94b022d to 6ba0fab Oct 27, 2019
@SimonSapin
Copy link
Member Author

SimonSapin commented Oct 27, 2019

Ah, pre-review testing of PRs was yet another code path in decision_task.py. That’s a bit unfortunate.
@jdm
Copy link
Member

jdm commented Oct 28, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Oct 28, 2019

📌 Commit 6ba0fab has been approved by jdm
@highfive highfive assigned jdm and unassigned ferjm Oct 28, 2019
bors-servo added a commit that referenced this pull request Oct 28, 2019
@bors-servo
Auto merge of #24557 - servo:rustup, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
bb2c03a 
Upgrade to rustc 1.40.0-nightly (246be7e1a 2019-10-25)
@bors-servo
Copy link
Contributor

bors-servo commented Oct 28, 2019

⌛ Testing commit 6ba0fab with merge bb2c03a...
@bors-servo
Copy link
Contributor

bors-servo commented Oct 28, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: jdm
Pushing bb2c03a to master...
@bors-servo bors-servo merged commit 6ba0fab into master Oct 28, 2019
2 checks passed
2 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
homu Test successful
Details
@bors-servo bors-servo deleted the rustup branch Oct 28, 2019
@bors-servo bors-servo mentioned this pull request Oct 28, 2019
Merged
7 of 7 tasks complete
@jdm jdm mentioned this pull request Oct 29, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@SimonSapin @highfive @jdm @bors-servo @ferjm
You can’t perform that action at this time.