Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete superfluous comment #24565

Merged
merged 1 commit into from Oct 28, 2019
Merged

Delete superfluous comment #24565

merged 1 commit into from Oct 28, 2019

Conversation

@tkeri
Copy link
Contributor

tkeri commented Oct 28, 2019

No description provided.

Deleted unnecessary commit, because
the 'WebGLSampler' was implemented.
@highfive
Copy link

highfive commented Oct 28, 2019

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon.

@highfive
Copy link

highfive commented Oct 28, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/webidls/WebGL2RenderingContext.webidl
  • @KiChjang: components/script/dom/webidls/WebGL2RenderingContext.webidl
@highfive
Copy link

highfive commented Oct 28, 2019

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@jdm
Copy link
Member

jdm commented Oct 28, 2019

@bors-servo r+
Thanks!

@bors-servo
Copy link
Contributor

bors-servo commented Oct 28, 2019

📌 Commit e27b80a has been approved by jdm

@highfive highfive assigned jdm and unassigned Manishearth Oct 28, 2019
@bors-servo
Copy link
Contributor

bors-servo commented Oct 28, 2019

Testing commit e27b80a with merge ac83c7f...

bors-servo added a commit that referenced this pull request Oct 28, 2019
Delete superfluous comment
@bors-servo
Copy link
Contributor

bors-servo commented Oct 28, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: jdm
Pushing ac83c7f to master...

@bors-servo bors-servo merged commit e27b80a into servo:master Oct 28, 2019
2 checks passed
2 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Oct 28, 2019
3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.