Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mach bootstrap - activate virtual env #24567

Merged
merged 2 commits into from Nov 15, 2019
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

@@ -223,7 +223,18 @@ class DummyContext(object):
pass


def is_firefox_checkout(topdir):
parentdir = os.path.normpath(os.path.join(topdir, '..'))
is_firefox = os.path.isfile(os.path.join(parentdir,
'build/mach_bootstrap.py'))
return is_firefox


def bootstrap_command_only(topdir):
# we should activate the venv before importing servo.boostrap
# because the module requires non-standard python packages
_activate_virtualenv(topdir, is_firefox_checkout(topdir))

from servo.bootstrap import bootstrap

context = DummyContext()
@@ -265,10 +276,7 @@ def bootstrap(topdir):
print('You are running Python', platform.python_version())
sys.exit(1)

# See if we're inside a Firefox checkout.
parentdir = os.path.normpath(os.path.join(topdir, '..'))
is_firefox = os.path.isfile(os.path.join(parentdir,
'build/mach_bootstrap.py'))
is_firefox = is_firefox_checkout(topdir)

_activate_virtualenv(topdir, is_firefox)

ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.