Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UWP: More mouse events #24597

Merged
merged 1 commit into from Nov 1, 2019
Merged

UWP: More mouse events #24597

merged 1 commit into from Nov 1, 2019

Conversation

@paulrouget
Copy link
Contributor

paulrouget commented Oct 31, 2019

Support more UWP Desktop events (mouse wheel, mouse move, etc).

This introduces a new issue, where the basic bbjs demo requires double click to select a color (unrelated to #24530 I believe). Filed #24596.

Next step is to properly fire touch events in HoloLens and only mouse events on Desktop (see #24587).
@paulrouget
Copy link
Contributor Author

paulrouget commented Oct 31, 2019

With this, we can scroll with a regular trackpad, and rotate in the basic bbjs demo.
@nox
Copy link
Member

nox commented Oct 31, 2019

r? @jdm

I am on le PTO
@highfive highfive assigned jdm and unassigned nox Oct 31, 2019
@jdm
jdm approved these changes Oct 31, 2019
View changes
ports/libmlservo/src/lib.rs
@@ -240,7 +240,7 @@ pub unsafe extern "C" fn move_servo(servo: *mut ServoInstance, x: f32, y: f32) {
match servo.scroll_state {
ScrollState::TriggerUp => {
servo.scroll_state = ScrollState::TriggerUp;
let _ = call(|s| s.move_mouse(x, y));
let _ = call(|s| s.mouse_move(x, y));

This comment has been minimized.

Sign in to view
Copy link
@jdm

jdm Oct 31, 2019

Member

This is surprisingly difficult for my brain to read 😅

This comment has been minimized.

Sign in to view
Copy link
@paulrouget

paulrouget Oct 31, 2019

Author Contributor

just to be consistent with other method names.
@jdm
Copy link
Member

jdm commented Oct 31, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Oct 31, 2019

📌 Commit 313469c has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Oct 31, 2019

⌛ Testing commit 313469c with merge ac568d9...
bors-servo added a commit that referenced this pull request Oct 31, 2019
@bors-servo
Auto merge of #24597 - paulrouget:mouse, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ac568d9 
UWP: More mouse events

Support more UWP Desktop events (mouse wheel, mouse move, etc).

This introduces a new issue, where the basic bbjs demo requires double click to select a color (unrelated to #24530 I believe). Filed #24596.

Next step is to properly fire touch events in HoloLens and only mouse events on Desktop (see #24587).
@bors-servo
Copy link
Contributor

bors-servo commented Oct 31, 2019

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented Oct 31, 2019 

error[E0599]: no method named `move_move` found for type `&mut simpleservo::ServoGlue` in the current scope
   --> ports/libmlservo/src/lib.rs:259:36
    |
259 |                 let _ = call(|s| s.move_move(x, y));
    |                                    ^^^^^^^^^ help: there is a method with a similar name: `mouse_move`

error: aborting due to previous error
@paulrouget
UWP: More mouse events
Loading status checks…
112221f
@paulrouget paulrouget force-pushed the paulrouget:mouse branch from 313469c to 112221f Nov 1, 2019
@paulrouget
Copy link
Contributor Author

paulrouget commented Nov 1, 2019

@bors-servo r=jdm
@bors-servo
Copy link
Contributor

bors-servo commented Nov 1, 2019

📌 Commit 112221f has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Nov 1, 2019

⌛ Testing commit 112221f with merge 6d9449b...
bors-servo added a commit that referenced this pull request Nov 1, 2019
@bors-servo
Auto merge of #24597 - paulrouget:mouse, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6d9449b 
UWP: More mouse events

Support more UWP Desktop events (mouse wheel, mouse move, etc).

This introduces a new issue, where the basic bbjs demo requires double click to select a color (unrelated to #24530 I believe). Filed #24596.

Next step is to properly fire touch events in HoloLens and only mouse events on Desktop (see #24587).
@bors-servo
Copy link
Contributor

bors-servo commented Nov 1, 2019

💔 Test failed - status-taskcluster
@CYBAI
Copy link
Collaborator

CYBAI commented Nov 1, 2019

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Nov 1, 2019

💣 Failed to start rebuilding: Unknown error
bors-servo added a commit that referenced this pull request Nov 1, 2019
@bors-servo
Auto merge of #24597 - paulrouget:mouse, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
48d918d 
UWP: More mouse events

Support more UWP Desktop events (mouse wheel, mouse move, etc).

This introduces a new issue, where the basic bbjs demo requires double click to select a color (unrelated to #24530 I believe). Filed #24596.

Next step is to properly fire touch events in HoloLens and only mouse events on Desktop (see #24587).
@bors-servo
Copy link
Contributor

bors-servo commented Nov 1, 2019

⌛ Testing commit 112221f with merge 48d918d...
@bors-servo
Copy link
Contributor

bors-servo commented Nov 1, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: jdm
Pushing 48d918d to master...
@bors-servo bors-servo merged commit 112221f into servo:master Nov 1, 2019
2 checks passed
2 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdm jdm

Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@paulrouget @nox @jdm @bors-servo @CYBAI @highfive
You can’t perform that action at this time.