Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store Option<ImageInfo> instead of making fields of ImageInfo optional #24616

Merged
merged 1 commit into from Nov 2, 2019
Merged

Store Option<ImageInfo> instead of making fields of ImageInfo optional #24616

merged 1 commit into from Nov 2, 2019

Conversation

@teapotd
Copy link
Contributor

teapotd commented Oct 31, 2019

Fixes #24582

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #24582
  • These changes do not require tests
@highfive
Copy link

highfive commented Oct 31, 2019

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @paulrouget (or someone else) soon.
@highfive
Copy link

highfive commented Oct 31, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/webgltexture.rs, components/script/dom/webglrenderingcontext.rs, components/script/dom/webgl_validations/tex_image_2d.rs, components/script/dom/webglframebuffer.rs
  • @KiChjang: components/script/dom/webgltexture.rs, components/script/dom/webglrenderingcontext.rs, components/script/dom/webgl_validations/tex_image_2d.rs, components/script/dom/webglframebuffer.rs
@highfive
Copy link

highfive commented Oct 31, 2019

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@jdm
Copy link
Member

jdm commented Oct 31, 2019

@bors-servo try=wpt
@bors-servo
Copy link
Contributor

bors-servo commented Oct 31, 2019

⌛ Trying commit a5a64f1 with merge 8935003...
bors-servo added a commit that referenced this pull request Oct 31, 2019
@bors-servo
Auto merge of #24616 - teapotd:imageinfo-option-refactoring, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8935003 
Store Option<ImageInfo> instead of making fields of ImageInfo optional

Fixes #24582

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #24582
- [X] These changes do not require tests
@jdm
jdm requested changes Oct 31, 2019
View changes
Copy link
Member

jdm left a comment

This is a great improvement! Thanks!
components/script/dom/webgltexture.rs Outdated Show resolved Hide resolved
components/script/dom/webgltexture.rs Outdated Show resolved Hide resolved
@jdm jdm assigned jdm and unassigned paulrouget Oct 31, 2019
@bors-servo
Copy link
Contributor

bors-servo commented Oct 31, 2019

💔 Test failed - linux-rel-wpt
@teapotd
Store Option<ImageInfo> instead of making fields optional
Loading status checks…
a4fa36f
@jdm
Copy link
Member

jdm commented Nov 1, 2019

@bors-servo try=wpt
@bors-servo
Copy link
Contributor

bors-servo commented Nov 1, 2019

⌛ Trying commit a4fa36f with merge 9b1687f...
bors-servo added a commit that referenced this pull request Nov 1, 2019
@bors-servo
Auto merge of #24616 - teapotd:imageinfo-option-refactoring, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9b1687f 
Store Option<ImageInfo> instead of making fields of ImageInfo optional

Fixes #24582

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #24582
- [X] These changes do not require tests
@bors-servo
Copy link
Contributor

bors-servo commented Nov 1, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
State: approved= try=True
@jdm
Copy link
Member

jdm commented Nov 1, 2019

@bors-servo r+
Thanks!
@bors-servo
Copy link
Contributor

bors-servo commented Nov 1, 2019

📌 Commit a4fa36f has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Nov 1, 2019

⌛ Testing commit a4fa36f with merge 4dc894d...
bors-servo added a commit that referenced this pull request Nov 1, 2019
@bors-servo
Auto merge of #24616 - teapotd:imageinfo-option-refactoring, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
4dc894d 
Store Option<ImageInfo> instead of making fields of ImageInfo optional

Fixes #24582

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #24582
- [X] These changes do not require tests
@bors-servo
Copy link
Contributor

bors-servo commented Nov 1, 2019

⛄ The build was interrupted to prioritize another pull request.
@bors-servo
Copy link
Contributor

bors-servo commented Nov 1, 2019

⌛ Testing commit a4fa36f with merge d619820...
bors-servo added a commit that referenced this pull request Nov 1, 2019
@bors-servo
Auto merge of #24616 - teapotd:imageinfo-option-refactoring, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d619820 
Store Option<ImageInfo> instead of making fields of ImageInfo optional

Fixes #24582

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #24582
- [X] These changes do not require tests
@bors-servo
Copy link
Contributor

bors-servo commented Nov 1, 2019

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented Nov 1, 2019

@bors-servo retry
#24622
bors-servo added a commit that referenced this pull request Nov 1, 2019
@bors-servo
Auto merge of #24616 - teapotd:imageinfo-option-refactoring, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
cd9467e 
Store Option<ImageInfo> instead of making fields of ImageInfo optional

Fixes #24582

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #24582
- [X] These changes do not require tests
@bors-servo
Copy link
Contributor

bors-servo commented Nov 1, 2019

⌛ Testing commit a4fa36f with merge cd9467e...
@bors-servo
Copy link
Contributor

bors-servo commented Nov 1, 2019

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented Nov 2, 2019

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Nov 2, 2019

💣 Failed to start rebuilding: Unknown error
bors-servo added a commit that referenced this pull request Nov 2, 2019
@bors-servo
Auto merge of #24616 - teapotd:imageinfo-option-refactoring, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
56537fa 
Store Option<ImageInfo> instead of making fields of ImageInfo optional

Fixes #24582

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #24582
- [X] These changes do not require tests
@bors-servo
Copy link
Contributor

bors-servo commented Nov 2, 2019

⌛ Testing commit a4fa36f with merge 56537fa...
@bors-servo
Copy link
Contributor

bors-servo commented Nov 2, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: jdm
Pushing 56537fa to master...
@bors-servo bors-servo merged commit a4fa36f into servo:master Nov 2, 2019
2 checks passed
2 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
homu Test successful
Details
@teapotd teapotd deleted the teapotd:imageinfo-option-refactoring branch Nov 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdm jdm

Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Store Option<ImageInfo> instead of making fields of ImageInfo optional
5 participants
@teapotd @highfive @jdm @bors-servo @paulrouget
You can’t perform that action at this time.