Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use MessageEventSource on MessageEvent IDL #24636

Merged
merged 2 commits into from Nov 8, 2019
Merged

Use MessageEventSource on MessageEvent IDL #24636

merged 2 commits into from Nov 8, 2019

Conversation

@saschanaz
Copy link
Contributor

saschanaz commented Nov 4, 2019 •
edited

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #22617
  • There are tests for these changes OR
  • These changes do not require tests because ___
@highfive
Copy link

highfive commented Nov 4, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/bindings/codegen/CodegenRust.py, components/script/dom/bindings/conversions.rs, components/script/dom/webidls/MessageEvent.webidl, components/script/dom/messageevent.rs
  • @KiChjang: components/script/dom/bindings/codegen/CodegenRust.py, components/script/dom/bindings/conversions.rs, components/script/dom/webidls/MessageEvent.webidl, components/script/dom/messageevent.rs
@highfive
Copy link

highfive commented Nov 4, 2019

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify script code, but no tests are modified. Please consider adding a test!
@saschanaz saschanaz changed the title Windowproxy Use MessageEventSource on MessageEvent IDL Nov 4, 2019
@saschanaz
Copy link
Contributor Author

saschanaz commented Nov 4, 2019

@bors-servo try=wpt
@bors-servo
Copy link
Contributor

bors-servo commented Nov 4, 2019

⌛ Trying commit 0eda5cf with merge e6da6a6...
bors-servo added a commit that referenced this pull request Nov 4, 2019
@bors-servo
Auto merge of #24636 - saschanaz:windowproxy, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e6da6a6 
Use MessageEventSource on MessageEvent IDL

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [x] These changes fix #22617

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 4, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
State: approved= try=True
@nox
nox requested changes Nov 4, 2019
View changes
components/script/dom/bindings/conversions.rs Outdated Show resolved Hide resolved
saschanaz added 2 commits Nov 3, 2019
@saschanaz
Use MessageEventSource on MessageEvent IDL
f8b61c0
@saschanaz
Store source as an enum
Loading status checks…
cf46a9a
@saschanaz saschanaz force-pushed the saschanaz:windowproxy branch from 0eda5cf to cf46a9a Nov 4, 2019
@gterzian
gterzian suggested changes Nov 5, 2019
View changes
Copy link
Member

gterzian left a comment

I think this could quite easily also close #24454
components/script/dom/messageevent.rs Show resolved Hide resolved
@gterzian gterzian mentioned this pull request Nov 5, 2019
Closed
@jdm
Copy link
Member

jdm commented Nov 7, 2019

@bors-servo r=nox,jdm
@bors-servo
Copy link
Contributor

bors-servo commented Nov 7, 2019

📌 Commit cf46a9a has been approved by nox,jdm
@bors-servo
Copy link
Contributor

bors-servo commented Nov 7, 2019

⌛ Testing commit cf46a9a with merge 77023be...
bors-servo added a commit that referenced this pull request Nov 7, 2019
@bors-servo
Auto merge of #24636 - saschanaz:windowproxy, r=nox,jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
77023be 
Use MessageEventSource on MessageEvent IDL

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22617

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 7, 2019

💔 Test failed - status-community-tc
@jdm
Copy link
Member

jdm commented Nov 7, 2019

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Nov 7, 2019

⌛ Testing commit cf46a9a with merge 54a84b8...
bors-servo added a commit that referenced this pull request Nov 7, 2019
@bors-servo
Auto merge of #24636 - saschanaz:windowproxy, r=nox,jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
54a84b8 
Use MessageEventSource on MessageEvent IDL

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22617

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 8, 2019

💔 Test failed - status-community-tc
@jdm
Copy link
Member

jdm commented Nov 8, 2019

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Nov 8, 2019

⌛ Testing commit cf46a9a with merge 3cf6540...
bors-servo added a commit that referenced this pull request Nov 8, 2019
@bors-servo
Auto merge of #24636 - saschanaz:windowproxy, r=nox,jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3cf6540 
Use MessageEventSource on MessageEvent IDL

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22617

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 8, 2019

💔 Test failed - status-community-tc
@CYBAI
Copy link
Collaborator

CYBAI commented Nov 8, 2019

@bors-servo retry

  • cygwin oom
@bors-servo
Copy link
Contributor

bors-servo commented Nov 8, 2019

💣 Failed to start rebuilding: 405 Not Allowed
@bors-servo
Copy link
Contributor

bors-servo commented Nov 8, 2019

⌛ Testing commit cf46a9a with merge df9065a...
bors-servo added a commit that referenced this pull request Nov 8, 2019
@bors-servo
Auto merge of #24636 - saschanaz:windowproxy, r=nox,jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
df9065a 
Use MessageEventSource on MessageEvent IDL

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22617

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 8, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-community-tc, status-taskcluster
Approved by: nox,jdm
Pushing df9065a to master...
@bors-servo bors-servo merged commit cf46a9a into servo:master Nov 8, 2019
2 checks passed
2 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
homu Test successful
Details
@saschanaz saschanaz deleted the saschanaz:windowproxy branch Nov 8, 2019
@SimonSapin SimonSapin mentioned this pull request Dec 25, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdm jdm

@gterzian gterzian

@nox nox

Assignees

@nox nox

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

WindowProxy interface is considered only exposed to Window environment
7 participants
@saschanaz @highfive @bors-servo @jdm @CYBAI @nox @gterzian
You can’t perform that action at this time.